esp32: Explicitly fail on boot-up for unsupported ESP32 versions #11563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is intended to update the EFUSE's register content and update related configs: - Remove duplicated configs from `esp32_soc.h`; - Add missing header files from APB registers; - Add missing macro definitions from EFUSE; - Update related code to use the new macros;
ESP32 is supported on NuttX starting from chip revision 3.0. This, however, didn't prevent the user from using older chip revisions, which caused unexpected behaviors. This commit checks chip revision before finishing booting NuttX.
Espressif's MCUboot should be built from sources.
alandeassis
approved these changes
Jan 19, 2024
xiaoxiang781216
approved these changes
Jan 21, 2024
Contributor
|
I noticed that my esp32-devkitc board does not boot withi this PR. |
Contributor
|
Also, |
Contributor
Author
Hi @masayuki2009! Chip revisions before the v3.0 require a lot of workarounds to fix all the known issues and we don't aim to fully support them on NuttX (you can check https://www.espressif.com/sites/default/files/documentation/esp32_chip_revision_v3_0_user_guide_en.pdf as a reference). This limitation was already true, we just made it clear with this MR because we have received some bug reports regarding old chips. You can ignore the check by setting |
Contributor
Author
Are you using Espressif's port of QEMU? It is possible to set virtual refuses to make it behave as a chip revision > 3.0: https://github.com/espressif/esp-toolchain-docs/blob/main/qemu/esp32/README.md#emulating-esp32-eco3 |
Contributor
Yes.
Thanks for the information. |
Contributor
Author
you can use this as the content of the bin file to the virtual refuses ;) |
Contributor
|
@tmedicci |
Contributor
what problems does older esp32 versions have? |
Contributor
Probably because you are using recent ESP32 chips (ECO 3), the issue on happens on pretty old silicon versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
esp32: Explicitly fail on boot-up for unsupported ESP32 versions:
esp32/hardware/esp32_efuse.h: Update macros for registers:
esp32_soc.h;esp32/hardware: Rename
efuse_reg.htoesp32_efuse.h.Impact
Prevent users to use unsupported older versions of ESP32.
Testing
Internal CI testing + ESP32 from different versions.