rptun dump: move rptun_dump.c to rptun.c, remove redundant code. #11712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiang781216
approved these changes
Feb 18, 2024
wyr8899
force-pushed
the
rptun-dump-dev
branch
2 times, most recently
from
566f521 to
7841f1c
Compare
CV-Bowen
reviewed
Feb 19, 2024
Signed-off-by: wangyongrong <wangyongrong@xiaomi.com>
wyr8899
force-pushed
the
rptun-dump-dev
branch
from
7841f1c to
9dc7fe3
Compare
CV-Bowen
added a commit
to CV-Bowen/incubator-nuttx
that referenced
this pull request
Sep 18, 2024
rptun_dump related code has been moved to rptun.c from rptun_dump.c, but file rptun_dump.c is not deleted in PR: apache#11712 So delete this file. Signed-off-by: Bowen Wang <wangbowen6@xiaomi.com>
CV-Bowen
added a commit
to CV-Bowen/incubator-nuttx
that referenced
this pull request
Sep 24, 2024
rptun_dump related code has been moved to rptun.c from rptun_dump.c, but file rptun_dump.c is not deleted in PR: apache#11712 So delete this file. Signed-off-by: Bowen Wang <wangbowen6@xiaomi.com>
xiaoxiang781216
pushed a commit
that referenced
this pull request
Sep 25, 2024
rptun_dump related code has been moved to rptun.c from rptun_dump.c, but file rptun_dump.c is not deleted in PR: #11712 So delete this file. Signed-off-by: Bowen Wang <wangbowen6@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rptun dump: move rptun_dump.c to rptun.c, remove redundant code.
Impact
simplify code logic.
Testing
tested in sim vela and 86panel.