sched/group: set clear flag if the group is not really needed #11885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The delete flag is not synchronized with the life cycle of the group, if the flag set before waitpid(), the tcb will be mistakenly deleted by group_del_waiter(), use-after-free will happen. Regression by: | commit 29e50ff (origin/master, origin/HEAD) | Author: chao an <anchao@lixiang.com> | Date: Mon Mar 4 09:19:27 2024 +0800 | | sched/group: move task group into task_tcb_s to improve performance | | move task group into task_tcb_s to avoid access allocator to improve performance | | for Task Termination, the time consumption will be reduced ~2us (Tricore TC397 300MHZ): | 15.97(us) -> 13.55(us) | | Signed-off-by: chao an <anchao@lixiang.com> Signed-off-by: chao an <anchao@lixiang.com>
Contributor
Author
|
@masayuki2009 @xiaoxiang781216 @acassis
|
Contributor
|
@anchao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sched/group: set clear flag if the group is not really needed
The delete flag is not synchronized with the life cycle of the group, if the flag set before waitpid(), the tcb will be mistakenly deleted by group_del_waiter(), use-after-free will happen.
Regression by:
Impact
N/A
Testing
rv-virt:ksmp64