stm32h7/stm32_i2c: fix sending large data over i2c #12093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To trigger TC interrupt NBYTES needs to be set before RELOAD is disabled
pkarashchenko
approved these changes
Apr 7, 2024
xiaoxiang781216
approved these changes
Apr 7, 2024
acassis
approved these changes
Apr 7, 2024
Contributor
|
Nice finding @Igor-Misic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a very nasty bug in the I2C driver for STM32H7 MCUs if anyone tries sending a chunk of data larger than 255 bytes.
For TC interrupt to be triggered NBYTES needs to be set before RELOAD is disabled, otherwise, an interrupt will never happen, and implemented logic for handling data larger than 255 bytes will not work.