Revert "irq: add [enter|leave]_critical_section_nonirq" #13485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiang781216
approved these changes
Sep 16, 2024
Contributor
|
@hujun260 please include the reason this commit needs to be reverted. What issue have you found? Is it possible to create a unit test to detect the issue to avoid it happens again? |
Contributor
No issue is found with this change. Because the optimization done by #13486 make that _noirq don't have significant benefit. |
xiaoxiang781216
approved these changes
Sep 17, 2024
This reverts commit 1c5a0bf. Signed-off-by: hujun5 <hujun5@xiaomi.com>
xiaoxiang781216
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reverts commit 1c5a0bf.
Impact
Testing