-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fs/reference_count: set default reference count option depends on DISABLE_PTHREAD #13519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
[Experimental Bot, please feedback here] NuttX PR Requirement CheckWhile this PR description provides some information, it does not fully meet the NuttX requirements. Here's a breakdown: Strengths:
Weaknesses:
Recommendations for Improvement
By addressing these points, you can significantly improve the clarity and completeness of your PR, making it easier for reviewers to understand and approve your changes. |
xiaoxiang781216
approved these changes
Dec 11, 2024
Contributor
|
@anchao need fix the ci error. |
…ABLE_PTHREAD Most of developers will not have the scenarios of open/close file descriptors in multi-threads, The default option will incur additional code size overhead for such devices. this PR will preserve the behavior before PR#13296 was introduced, and ensure that the default code size is not affected. Note that this option will ensure the safety of access to the file system from multi-tasks (Task A blocking rw(fd), then Task B close(fd)), the disadvantage is that it will increase the amount of code-size, there is no need to enable this option if the application could ensure he file operations are safe. Signed-off-by: chao an <anchao@lixiang.com>
Signed-off-by: chao an <anchao@lixiang.com>
xiaoxiang781216
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: File System
File System issues
Board: arm64
Size: XS
The size of the change in this PR is very small
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Most of developers will not have the scenarios of open/close file descriptors in multi-threads,
The default option will incur additional code size overhead for such devices.
this PR will preserve the behavior before PR #13296 was introduced, and ensure that the default code size is not affected.
Note that this option will ensure the safety of access to the file
system from multi-tasks (Task A blocking rw(fd), then Task B close(fd)),
the disadvantage is that it will increase the amount of code-size,
there is no need to enable this option if the application could ensure
he file operations are safe.
Original:
After introduce FS_REFCOUNT:
text +528
bss +64
Some developers do not need this kind of advanced features,
move sigev_notify_thread_id into SIG_EVTHREAD to save the code size.
This reverts commit 9a9d0a6.
This reverts commit 756faf3.
Signed-off-by: chao an anchao@lixiang.com
Impact
N/A
Testing
ci-check