Skip to content

Conversation

@Gary-Hobson
Copy link
Contributor

@Gary-Hobson Gary-Hobson commented Sep 18, 2024

Summary

Change DUMP_ON_EXIT to CONFIG_SCHED_DUMP_ON_EXIT and move it to the sched directory

Impact

Fix the bug in #13118, It uses undefined macros

Testing

Signed-off-by: yinshengkai <yinshengkai@xiaomi.com>
@lupyuen
Copy link
Member

lupyuen commented Sep 18, 2024

[Experimental Bot, please feedback here]

Does this PR meet the NuttX Requirements?

No, the PR is missing crucial information.

Here's what's missing and needs to be added:

Summary:

  • Why is this change necessary? Is it a bug fix? Code cleanup? Improved organization?
  • What functional part of the code is changing? Be specific. For example, "This changes the way the scheduler dumps its state on exit."
  • How does the change work? Explain the mechanism behind the change. For example, "This change renames the DUMP_ON_EXIT configuration option to CONFIG_SCHED_DUMP_ON_EXIT and moves its definition to the sched directory to improve code organization and clarity."

Impact:

  • Carefully consider and address ALL impact points. Even if the impact is "NO", state it explicitly (e.g., "Impact on build: NO").
  • For any "YES" impacts, provide details!

Testing:

  • What build hosts did you test this on? (OS, CPU architecture, compiler)
  • What target(s) did you test on? (architecture, board, configuration)
  • Provide the actual testing logs before and after the change to demonstrate the impact.

Example of improved testing section:

Testing

I confirm that changes are verified on the local setup and work as intended:

  • Build Host(s):
    • Ubuntu 22.04, x86_64, GCC 11.3.0
  • Target(s):
    • sim:nsh configuration

Testing logs before change:

<Insert logs from running your test case before the change>

Testing logs after change:

<Insert logs from running your test case after the change> 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants