Skip to content

Conversation

@OceanfromXiaomi
Copy link
Contributor

Summary

add the ability that control CAN transceiver state in nuttx.
add can controller state setting and getting in uppercan.

Impact

Testing

add can controller state setting and getting in uppercan.

Signed-off-by: zhaohaiyang1 <zhaohaiyang1@xiaomi.com>
add the ability that control CAN transceiver state in nuttx.

Signed-off-by: zhaohaiyang1 <zhaohaiyang1@xiaomi.com>
@github-actions github-actions bot added the Size: M The size of the change in this PR is medium label Sep 30, 2024
@nuttxpr
Copy link

nuttxpr commented Sep 30, 2024

[Experimental Bot, please feedback here]

This Pull Request appears incomplete based on the provided NuttX requirements.

Here's why and what's missing:

  • Insufficient Summary:

    • What functional part is changed? Be specific. Is it a new driver? Changes to existing CAN APIs?
    • How does the change work? Explain the mechanism used to control the CAN transceiver state.
    • Link any related issues. This helps reviewers understand the context and problem being solved.
  • Impact Section Needs Completion:

    • You need to go through each impact category (user, build, hardware, documentation, security, compatibility) and mark them as NO or YES. If YES, provide a description.
    • Examples:
      • Impact on user: YES - Users can now control the CAN transceiver state using the new APIs.
      • Impact on hardware: YES - This affects boards with CAN controllers [List specific boards/controllers].
  • Testing is Insufficient:

    • Provide build host details: Which OS, CPU architecture, and compiler version did you use for testing?
    • Target details are crucial: Specify the exact architectures (e.g., sim:nsh, arm:stm32f4discovery) and board configurations tested.
    • Missing logs: Include relevant logs from before and after your changes. This demonstrates the issue and the fix. Logs should show:
      • CAN initialization
      • Attempts to control the transceiver state (before and after your changes)
      • Any relevant error messages or successful state transitions

Recommendations:

  1. Expand the Summary: Provide the missing details about the code changes and their functionality.
  2. Complete the Impact Assessment: Carefully consider and document the impact of your changes on all aspects.
  3. Provide Detailed Testing Information: Include specific build host and target details. Add relevant logs that demonstrate the problem being solved and the effectiveness of your fix.

By providing this information, you'll make it much easier for reviewers to understand, evaluate, and (hopefully) merge your Pull Request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: M The size of the change in this PR is medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants