Skip to content

Conversation

@szafonimateusz-mi
Copy link
Contributor

Summary

arch/intel64: fix IRQ conflict with GOLDFISH
Also move MSI IRQ definition to place where other IRQ definitions are.

Impact

x86_64 can be used with android goldfish. No impact on user.

Testing

CI

Also move MSI IRQ definition to place where other IRQ definitions are.

Signed-off-by: p-szafonimateusz <p-szafonimateusz@xiaomi.com>
@github-actions github-actions bot added Arch: x86_64 Issues related to the x86_64 architecture Size: S The size of the change in this PR is small labels Oct 3, 2024
@nuttxpr
Copy link

nuttxpr commented Oct 3, 2024

[Experimental Bot, please feedback here]

Yes, this PR appears to meet the NuttX requirements.

Here's why:

  • Summary:
    • Provides a clear reason for the change ("fix IRQ conflict with GOLDFISH").
    • Specifies the affected code area ("arch/intel64").
    • Briefly describes the technical implementation ("move MSI IRQ definition").
  • Impact:
    • Addresses all impact categories.
    • Clearly states "NO" for most impact areas, indicating no significant user-facing or system changes.
    • Highlights the positive impact: "x86_64 can be used with android goldfish."
  • Testing:
    • Relies on CI, which is acceptable for common architectures like x86_64 if the CI has good test coverage for that architecture.
    • Providing specific build host and target details would further strengthen the testing section, but it might not be strictly required if the CI is comprehensive.

Suggestion: While not mandatory, including links to the CI runs for this PR would enhance transparency and make it easier for reviewers to assess the testing.

@xiaoxiang781216 xiaoxiang781216 merged commit b47839b into apache:master Oct 3, 2024
@szafonimateusz-mi szafonimateusz-mi deleted the goldfish_irq branch April 29, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch: x86_64 Issues related to the x86_64 architecture Size: S The size of the change in this PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants