Skip to content

Conversation

@szafonimateusz-mi
Copy link
Contributor

Summary

colorize IDLE stack for AP cores in x86_64

Impact

CONFIG_STACK_COLORATION=y works also for AP cores IDLE stack

Testing

qemu

colorize IDLE stack for AP cores in x86_64

Signed-off-by: p-szafonimateusz <p-szafonimateusz@xiaomi.com>
@github-actions github-actions bot added Arch: x86_64 Issues related to the x86_64 architecture Size: S The size of the change in this PR is small labels Oct 3, 2024
@nuttxpr
Copy link

nuttxpr commented Oct 3, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX Requirements.

Missing Information:

  • Summary:
    • Why is this change necessary? Is there a bug being fixed? Is this a new feature request?
    • How does the change work? Provide a technical explanation of how the IDLE stack coloration is implemented for AP cores.
  • Impact:
    • Is this a new feature? If so, clarify this in the Impact section.
    • Impact on documentation: Will the documentation need to be updated to reflect this change?
  • Testing:
    • Build Host(s): Provide details about your build host environment (OS, CPU, compiler version).
    • Target(s): Specify the architecture and board configuration used for testing.
    • Testing Logs: Include relevant testing logs from before and after the change.

Recommendations:

  1. Expand the Summary: Clearly state the purpose of the change, whether it's a bug fix, new feature, or enhancement. Explain the technical details of how the change is implemented.
  2. Complete the Impact Section: Address all impact points, especially if documentation updates are required.
  3. Provide Detailed Testing Information: Specify your build host and target environments, and include relevant testing logs demonstrating the change's effect.

By providing the missing information, you will make your PR easier for reviewers to understand and approve.

@xiaoxiang781216 xiaoxiang781216 merged commit 026e1b4 into apache:master Oct 3, 2024
@masayuki2009
Copy link
Contributor

@szafonimateusz-mi
I noticed qemu-intel64:smp does not boot now with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch: x86_64 Issues related to the x86_64 architecture Size: S The size of the change in this PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants