Refine inet layout, no function change #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and remove udp_psock_send.c Change-Id: I4e119520e3e40cc3411ec1279c03c54dd2ec62c4 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
and remove inet_close.c Change-Id: I8ed7c1e180bc1fde51ff5ad92b86c80c00a8c871 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
and remove inet_recvfrom.c Change-Id: Id79e6e160a45489548ed03538ff10b9331ecbe34 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
patacongo
reviewed
Jan 21, 2020
| struct tcp_close_s | ||
| { | ||
| FAR struct devif_callback_s *cl_cb; /* Reference to TCP callback instance */ | ||
| FAR struct socket *cl_psock; /* Reference to the TCP socket */ | ||
| sem_t cl_sem; /* Signals disconnect completion */ | ||
| int cl_result; /* The result of the close */ | ||
| }; | ||
| #endif |
Contributor
There was a problem hiding this comment.
Why do you remove these dependencies on NET_TCP_HAVE_STACK. Doesn't that break the USRSOCK case. That is what those defines are for?
Contributor
There was a problem hiding this comment.
Did you move these checkes elsewhere? Is the file not built is !NET_TCP_HAVE_STACK
Contributor
Author
There was a problem hiding this comment.
inet_close.c doesn't exist anymore, the code move into tcp/tcp_close.c or udp/udp_close.c. Since tcp/udp folder don't compiled if only USRSOCK is enabled, that is why I remove the check.
Contributor
Author
There was a problem hiding this comment.
Since inet_close.c is very similar to tcp_close.c, git consider it is the move operation and show the difference between inet_close.c(removed) and tcp_close.c(new), but tcp_close.c don't compile at all if CONFIG_NET_TCP isn't enabled.
Donny9
added a commit
to Donny9/incubator-nuttx
that referenced
this pull request
Jul 26, 2021
…system boot
So avoid to use vmov.i32 instruction before FPU is ready.
Before modification:
3c03b35c <nx_vsyslog>:
3c03b35c: f2c00010 vmov.i32 d16, #0 ; 0x00000000
3c03b360: f2c02050 vmov.i32 q9, #0 ; 0x00000000
3c03b364: e92d40f0 push {r4, r5, r6, r7, lr}
3c03b368: e24dd08c sub sp, sp, apache#140 ; 0x8c
3c03b36c: e28d301c add r3, sp, apache#28
3c03b370: e2505000 subs r5, r0, #0
3c03b374: edcd0b0f vstr d16, [sp, apache#60] ; 0x3c
3c03b378: edcd0b01 vstr d16, [sp, apache#4]
After modification:
3c03b35c <nx_vsyslog>:
3c03b35c: e92d40f0 push {r4, r5, r6, r7, lr}
3c03b360: e2505000 subs r5, r0, #0
3c03b364: e24dd08c sub sp, sp, apache#140 ; 0x8c
3c03b368: e1a06001 mov r6, r1
3c03b36c: e1a07002 mov r7, r2
3c03b370: e28d000c add r0, sp, apache#12
3c03b374: 1a00003a bne 3c03b464 <nx_vsyslog+0x108>
Change-Id: I643c19f5416c94a529764fdaa81f3088fcf95355
Signed-off-by: Jiuzhu Dong <dongjiuzhu1@xiaomi.com>
xiaoxiang781216
pushed a commit
that referenced
this pull request
Jul 26, 2021
…system boot
So avoid to use vmov.i32 instruction before FPU is ready.
Before modification:
3c03b35c <nx_vsyslog>:
3c03b35c: f2c00010 vmov.i32 d16, #0 ; 0x00000000
3c03b360: f2c02050 vmov.i32 q9, #0 ; 0x00000000
3c03b364: e92d40f0 push {r4, r5, r6, r7, lr}
3c03b368: e24dd08c sub sp, sp, #140 ; 0x8c
3c03b36c: e28d301c add r3, sp, #28
3c03b370: e2505000 subs r5, r0, #0
3c03b374: edcd0b0f vstr d16, [sp, #60] ; 0x3c
3c03b378: edcd0b01 vstr d16, [sp, #4]
After modification:
3c03b35c <nx_vsyslog>:
3c03b35c: e92d40f0 push {r4, r5, r6, r7, lr}
3c03b360: e2505000 subs r5, r0, #0
3c03b364: e24dd08c sub sp, sp, #140 ; 0x8c
3c03b368: e1a06001 mov r6, r1
3c03b36c: e1a07002 mov r7, r2
3c03b370: e28d000c add r0, sp, #12
3c03b374: 1a00003a bne 3c03b464 <nx_vsyslog+0x108>
Change-Id: I643c19f5416c94a529764fdaa81f3088fcf95355
Signed-off-by: Jiuzhu Dong <dongjiuzhu1@xiaomi.com>
pwnall
pushed a commit
to pwnall/nuttx
that referenced
this pull request
Oct 23, 2024
…system boot
So avoid to use vmov.i32 instruction before FPU is ready.
Before modification:
3c03b35c <nx_vsyslog>:
3c03b35c: f2c00010 vmov.i32 d16, #0 ; 0x00000000
3c03b360: f2c02050 vmov.i32 q9, #0 ; 0x00000000
3c03b364: e92d40f0 push {r4, r5, r6, r7, lr}
3c03b368: e24dd08c sub sp, sp, apache#140 ; 0x8c
3c03b36c: e28d301c add r3, sp, apache#28
3c03b370: e2505000 subs r5, r0, #0
3c03b374: edcd0b0f vstr d16, [sp, apache#60] ; 0x3c
3c03b378: edcd0b01 vstr d16, [sp, apache#4]
After modification:
3c03b35c <nx_vsyslog>:
3c03b35c: e92d40f0 push {r4, r5, r6, r7, lr}
3c03b360: e2505000 subs r5, r0, #0
3c03b364: e24dd08c sub sp, sp, apache#140 ; 0x8c
3c03b368: e1a06001 mov r6, r1
3c03b36c: e1a07002 mov r7, r2
3c03b370: e28d000c add r0, sp, apache#12
3c03b374: 1a00003a bne 3c03b464 <nx_vsyslog+0x108>
Change-Id: I643c19f5416c94a529764fdaa81f3088fcf95355
Signed-off-by: Jiuzhu Dong <dongjiuzhu1@xiaomi.com>
(cherry picked from commit 696bf0d368a62493c3d7462735127ed2c6ef7594)
Signed-off-by: Jiuzhu Dong <dongjiuzhu1@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.