-
Notifications
You must be signed in to change notification settings - Fork 1.5k
modlib:bug fix,allow 64bit elf load and if sym is NULL not load symbol #14205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[Experimental Bot, please feedback here] No, this PR does not meet the NuttX requirements. Here's why and how to improve it:
How to Improve the PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK on rv-virt:knsh, rv-virt:knsh64 and milkv_duos:nsh. Stress Test OK with 20 iterations of knsh64. Thanks!
NuttShell (NSH) NuttX-10.1.0
nsh> uname -a
NuttX 10.1.0 203b37992e Oct 13 2024 17:38:01 risc-v rv-virt
nsh> ostest
ostest_main: Exiting with status 0
|
@anjiahao1 The build should be fixed by apache/nuttx-apps#2716 |
Signed-off-by: anjiahao <anjiahao@xiaomi.com>
Signed-off-by: anjiahao <anjiahao@xiaomi.com>

Summary
modlib bug fix
Impact
modlib
Testing
rv-virt:knshandrv-virt:knsh64with ostest and getprime, pass it