Skip to content

Conversation

@XuNeo
Copy link
Contributor

@XuNeo XuNeo commented Oct 14, 2024

Note: Please adhere to Contributing Guidelines.

Summary

  1. Config multi line output to mode 3, so isort and black can agree with
    each other:
3 - Vertical Hanging Indent

from third_party import (
    lib1,
    lib2,
    lib3,
    lib4,
)
  1. Exit with error if python code needs to format

Impact

No impact.

Testing

CI build pass.

@github-actions github-actions bot added Area: Tooling Area: CI Size: XS The size of the change in this PR is very small labels Oct 14, 2024
Make CI fail if format not pass.

Signed-off-by: xuxingliang <xuxingliang@xiaomi.com>
Config multi line output to mode 3, so isort and black can agree with
each other:
```
3 - Vertical Hanging Indent

from third_party import (
    lib1,
    lib2,
    lib3,
    lib4,
)
```

Signed-off-by: xuxingliang <xuxingliang@xiaomi.com>
@XuNeo XuNeo force-pushed the py-code-check-update branch from 4dfea82 to a76663d Compare October 14, 2024 12:05
@xiaoxiang781216 xiaoxiang781216 merged commit 143b265 into apache:master Oct 14, 2024
@XuNeo XuNeo deleted the py-code-check-update branch October 15, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: CI Area: Tooling Size: XS The size of the change in this PR is very small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants