-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{Bp-14267} tools/espressif: add esptool version check to Espressif build system #14268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@fdcavalcanti please check 12.7 release |
|
Not sure what is happening on the CI |
|
Hi @jerpelea, how is this backport PR different from the one I created? |
|
@fdcavalcanti it is a backport. |
My PR was already targeting the release 12.7. Am I missing something? Should I change that one to target master? |
|
after i created the backport you force-pushed the patch so I had to force-push this one manually |
Thanks @jerpelea |
|
CI issue is new pip rules not allowing packages installed system-wide. |
|
@fdcavalcanti backported |
@fdcavalcanti please rebase yours on master |
cederom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah this is backport to releases/12.7 sorry :-) After #14267 is updated and merged go ahead, thank you!! :-)
|
please merge after CI passes |
Summary
Add a Python script to check if esptool is installed and if its version is up-to-date (see minimum version at ESPTOOL_MIN_VERSION on .mk files).
This fixes build issues as reported in #13824.
Impact
New Python script added. Stops build if esptool version is below 4.8.
Script runs for ESP32, S2, S3, C3, C6.
Testing
Tested locally and on internal CI with Python3.8+.
NOTE
backported #14176 to fix the CI