Skip to content

Conversation

@jerpelea
Copy link
Contributor

Summary

turn off interface by checking IFF_UP flag isn't set: #1838

Impact

RELEASE

Testing

CI

turn off interface by checking IFF_UP flag isn't set:
apache#1838

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@github-actions github-actions bot added Area: Networking Effects networking subsystem Area: Board support Board support issues Size: S The size of the change in this PR is small labels Oct 15, 2024
@jerpelea
Copy link
Contributor Author

backport from #13842

@jerpelea
Copy link
Contributor Author

@lupyuen CI is broken

@lupyuen
Copy link
Member

lupyuen commented Oct 15, 2024

@jerpelea Just fixed, please rebase: #14290

@jerpelea jerpelea changed the title {Bp-13842} }net: Remove IFF_DOWN flag to compatible with Linux/*BSD {Bp-13842} net: Remove IFF_DOWN flag to compatible with Linux/*BSD Oct 15, 2024
@jerpelea
Copy link
Contributor Author

jerpelea commented Oct 15, 2024

@jerpelea Just fixed, please rebase: #14290

@lupyuen the patch is unrelated

CI ERROR
Run echo "::add-matcher::nuttx/.github/nxstyle.json"
error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try apt install
python3-xyz, where xyz is the package you are trying to
install.

If you wish to install a non-Debian-packaged Python package,
create a virtual environment using python3 -m venv path/to/venv.
Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
sure you have python3-full installed.

If you wish to install a non-Debian packaged Python application,
it may be easiest to use pipx install xyz, which will manage a
virtual environment for you. Make sure you have pipx installed.

See /usr/share/doc/python3.12/README.venv for more information.

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 668 for the detailed specification.
Error: Process completed with exit code 1.

@lupyuen
Copy link
Member

lupyuen commented Oct 15, 2024

@acassis @cederom Same error here sigh. Wish I learnt some Python.

@fdcavalcanti
Copy link
Contributor

@acassis @cederom Same error here sigh. Wish I learnt some Python.

Problem is newer Python/pip versions do not allow you to install packages system wide. You must install them inside a virtual environment. I suggest a new issue is opened regarding this, as it only affects linting of Python files.

@lupyuen
Copy link
Member

lupyuen commented Oct 15, 2024

@fdcavalcanti Problem is that we are urgently rolling out a new NuttX Release right now. So we need to fix this now ... Or roll back to the earlier version before the fixes?

@fdcavalcanti
Copy link
Contributor

@fdcavalcanti Problem is that we are urgently rolling out a new NuttX Release right now. So we need to fix this now ... Or roll back to the earlier version before the fixes?

Let me try and fix this real quick.

@lupyuen
Copy link
Member

lupyuen commented Oct 15, 2024

@jerpelea Sorry I have a terrible, drastic suggestion:
(1) Could we freeze all merging to master for a few days (nuttx and nuttx-apps)
(2) Ask all stakeholders to test master on their respective boards
(3) Merge to master only the urgent fixes that we need
(4) Release master as the New NuttX Release
(5) Because we are seeing too many merges over the past weekend, it might cause more problems. Thank you so much 🙏

@jerpelea
Copy link
Contributor Author

@jerpelea Sorry I have a terrible, drastic suggestion: (1) Could we freeze all merging to master for a few days (2) Ask all stakeholders to test master on their respective boards (3) Merge to master only the urgent fixes that we need (4) Release master as the New NuttX Release (5) Because we are seeing too many merges over the past weekend, it might cause more problems. Thank you so much 🙏

I this that is really not a good idea but if this is the community wish we can go down this rabbit hole

CI Issues
The CI is common for both release branch and master (now broken by a patch merged in the past 20 h)

Release branch facts
1.the release branch compiles fine locally / we need some patches to unblock the release
2.the master patch has more problems than our release branch

I will let the community decide

@GUIDINGLI
Copy link
Contributor

GUIDINGLI commented Oct 15, 2024

@jerpelea Sorry I have a terrible, drastic suggestion: (1) Could we freeze all merging to master for a few days (nuttx and nuttx-apps) (2) Ask all stakeholders to test master on their respective boards (3) Merge to master only the urgent fixes that we need (4) Release master as the New NuttX Release (5) Because we are seeing too many merges over the past weekend, it might cause more problems. Thank you so much 🙏

You can lock the master, but not Today, suggest lock from next week.
Because lots of patches are merging to master from Xiaomi currently, we plan finish this job at this week.

@GUIDINGLI
Copy link
Contributor

After this upload to the community is completed, we plan to upload once a month in the future to ensure that there won't be so many patches uploaded at the same time.

@lupyuen
Copy link
Member

lupyuen commented Oct 15, 2024

Yep we should probably sync the NuttX Release Schedule with the Xiaomi Release Schedule. Lesson Learnt: Please try not to release NuttX during the Golden Week Holidays and Lunar New Year :-)

@xiaoxiang781216 xiaoxiang781216 merged commit 002d898 into apache:releases/12.7 Oct 15, 2024
@jerpelea jerpelea deleted the bp-13842 branch June 23, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Board support Board support issues Area: Networking Effects networking subsystem Size: S The size of the change in this PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants