-
Notifications
You must be signed in to change notification settings - Fork 1.5k
clang:libclang_rt.builtins-xxx.a supports builtin #14472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[Experimental Bot, please feedback here] This PR summary is incomplete to assess if it meets NuttX requirements. Here's a breakdown of what's missing and why it's important: Missing Information in Summary
Missing Information in Impact
Missing Information in Testing
Conclusion This PR, in its current state, does not meet NuttX requirements. The missing information makes it impossible to evaluate the change effectively. Please provide the missing details to ensure your PR receives proper review. |
|
@W-M-R please add a config to ensure the porting really work. |
OK, I'll turn on builtin by default |
|
please rebase to fix the ci error |
|
This CI result is a bit strange. The compiler clang used by Docker is 17.0.1, but it is inconsistent with the local compilation result of mine. I will to build a Docker to verify it latter. |
1. enable CONFIG_BUILTIN_COMPILER_RT to built libclang_rt.builtins-xxx.a and no longer use the compiler's built-in 2. Modify clang version acquisition to get two decimal points 3. It has been ported to support four architectures: ARM, ARM64, RISCV, and x86_64, among which ARM has been validated Signed-off-by: wangmingrong1 <wangmingrong1@xiaomi.com>
|
There is a problem with testbuild.sh, which causes the config I uploaded using the clang compiler to fail verification. I will fix this problem in the next patch and upload a defconfig that supports compiling this builtin. |
Summary
Impact
Testing