-
Notifications
You must be signed in to change notification settings - Fork 1.5k
cmake:implement CMake build of xtensa arch #14592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
configure:cmake -B build -DBOARD_CONFIG=iss-hifi4:nsh build:cmake --build build run:xt-run build/nuttx Signed-off-by: xuxin19 <xuxin19@xiaomi.com>
|
[Experimental Bot, please feedback here] No, this PR description does not fully meet the NuttX requirements. While it provides some information, it lacks crucial details in almost every section. Here's a breakdown of what's missing and how it can be improved: Summary:
Impact:
Testing:
Example of an Improved Summary: This PR implements CMake as an alternative build system for the Xtensa architecture. The current Makefile-based build system, while functional, can be complex and difficult to extend. CMake offers a more modern, cross-platform build system that simplifies the build process, improves maintainability, and enables easier integration with other tools. This implementation involves adding CMakeLists.txt files to the Xtensa architecture directory and modifying the configuration system to support CMake generation. This addresses [NuttX Issue #123](replace with actual issue number if applicable). By providing these missing details, the PR will be much easier for reviewers to understand, evaluate, and ultimately merge. A complete and thorough PR description greatly improves the chances of a successful contribution. |
acassis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xuxin930 iss-hifi4 is not in mainline, please test in some board existing in mainline
let's add chip/board in the new pr. |
Summary
implement CMake build of xtensa arch
Impact
new features and forward compatibility
Testing