Skip to content

Conversation

@jerpelea
Copy link
Contributor

@jerpelea jerpelea commented Nov 4, 2024

Summary
add the missing authors that have submitted ICLA

Impact
Authors

Testing
None

Tiago Medicci Serrano has submitted the ICLA and should be added to
the AUTHORS file

Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
Duo Zhang has submitted the ICLA and should be added to
the AUTHORS file

Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
Flavio Paiva Junqueira has submitted the ICLA and should be added to
the AUTHORS file

Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
Junping Du has submitted the ICLA and should be added to
the AUTHORS file

Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
Justin Mclean has submitted the ICLA and should be added to
the AUTHORS file

Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
Lup Yuen Lee has submitted the ICLA and should be added to
the AUTHORS file

Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
Mohammad Asif Siddiqui has submitted the ICLA and should be added to
the AUTHORS file

Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
Yanfeng Liu has submitted the ICLA and should be added to
the AUTHORS file

Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
Adam Feuer has submitted the ICLA and should be added to
the AUTHORS file

Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
Yamamoto Takashi has submitted the ICLA and should be added to
the AUTHORS file

Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
@github-actions github-actions bot added the Size: S The size of the change in this PR is small label Nov 4, 2024
@nuttxpr
Copy link

nuttxpr commented Nov 4, 2024

[Experimental Bot, please feedback here]

No. This PR does not adequately meet the NuttX requirements. While it attempts to address the summary and impact sections, it is far too brief and lacks critical information. The testing section is completely insufficient.

Here's why it's insufficient and what needs to be added:

  • Summary: "add the missing authors that have submitted ICLA" is vague. Which authors? Where are they missing from? What part of the codebase is affected? How were they added? A related issue number should be included if this addresses a reported problem.

  • Impact: Simply stating "Authors" isn't helpful. Explain the impact. Does this affect code ownership? Does it change anything functionally? All the "NO/YES" questions in the template must be answered individually.

  • Testing: "None" is unacceptable. Even if the change is purely administrative (like adding authors to a file), you need to demonstrate that the change was made correctly. For example, show the relevant section of the file before and after the change. If the authors are being added to allow them to be correctly credited for code contributions, show that the correct authors are now associated with their contributions (e.g., through git blame or similar).

Example of how to improve this PR description:

Summary: This PR adds the following authors, who have submitted ICLAs, to the AUTHORS file: John Doe and Jane Smith. They were previously missing, preventing them from being properly acknowledged for their contributions to the networking subsystem (specifically, the TCP/IP stack implementation). This addresses issue #123.

Impact:

  • Is new feature added? NO
  • Is existing feature changed? NO
  • Impact on user (will user need to adapt to change)? NO
  • Impact on build (will build process change)? NO
  • Impact on hardware (will arch(s) / board(s) / driver(s) change)? NO
  • Impact on documentation (is update required / provided)? YES (The AUTHORS file has been updated.)
  • Impact on security (any sort of implications)? NO
  • Impact on compatibility (backward/forward/interoperability)? NO
  • Anything else to consider? NO

Testing:

Build Host(s): Linux, x86_64, GCC 9.4.0
Target(s): N/A (This change only affects documentation.)

Testing logs before change (excerpt from AUTHORS):

... existing authors ...

Testing logs after change (excerpt from AUTHORS):

... existing authors ...
John Doe <john.doe@example.com>
Jane Smith <jane.smith@example.com>

By providing this level of detail, reviewers can quickly understand the change, its impact, and verify that it's correct. This will significantly speed up the review process.

@xiaoxiang781216 xiaoxiang781216 merged commit fdeaf53 into apache:master Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: S The size of the change in this PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants