Skip to content

Conversation

@gneworld
Copy link
Contributor

@gneworld gneworld commented Nov 6, 2024

Summary

Usage example for merging the factory partition and reserve partition into the merge partition:
register_merge_blockdriver("/dev/merge", "/dev/factory", "/dev/reserve", NULL)

Impact

FS

Testing

test on bes platform

@github-actions github-actions bot added Area: File System File System issues Size: M The size of the change in this PR is medium labels Nov 6, 2024
@nuttxpr
Copy link

nuttxpr commented Nov 6, 2024

[Experimental Bot, please feedback here]

No, this PR does not fully meet the NuttX requirements as described. While it provides a usage example and mentions testing, it lacks crucial information.

Here's a breakdown of missing information:

  • Summary: Needs to explain why this change is necessary. Is it a new feature? Fixing a bug? Improving performance? What problem does it solve? It also lacks any mention of related issues.
  • Impact: While it mentions "FS" (presumably filesystem), it needs to be far more specific. It needs to answer all the yes/no questions about user impact, build impact, hardware impact, documentation needs, security implications, and compatibility. Simply saying "FS" isn't helpful.
  • Testing: "test on bes platform" is insufficient. It needs to specify the host OS, CPU, compiler used for building, and the specific target architecture, board, and configuration. Most importantly, it lacks the required "before" and "after" testing logs. Without these logs, there's no evidence provided that the change actually works or improves anything.

In short, the PR needs significantly more detail to be considered complete.

@gneworld gneworld force-pushed the work1 branch 4 times, most recently from 7134586 to ab3fb88 Compare November 7, 2024 02:52
Usage example for merging the factory partition and reserve
partition into the merge partition:
register_merge_blockdriver("/dev/merge", "/dev/factory", "/dev/reserve",
NULL)

Signed-off-by: wanggang26 <wanggang26@xiaomi.com>
@lupyuen
Copy link
Member

lupyuen commented Nov 7, 2024

Sorry I have to cancel the CI Check, there's a problem with CI Test:

@xiaoxiang781216 xiaoxiang781216 merged commit 929bbf0 into apache:master Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: File System File System issues Size: M The size of the change in this PR is medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants