Skip to content

Conversation

@stbenn
Copy link
Contributor

@stbenn stbenn commented Nov 7, 2024

This commit adds files in preperation of adding ethernet drivers for the STM32H563 and Nucleo-H563ZI board. It also modifies the pinmap to include ethernet pins (and cleaned up leftover comments from L5 file), as well as add those pins to the board.h for the nucleo-h563zi.

Files added:

  • arch/arm/src/stm32h5/hardware/stm32_ethernet.h
  • arch/arm/src/stm32h5/hardware/stm32_sbs.h
    • Not fully implemented, just register necessary for ethernet driver.

Note: Please adhere to Contributing Guidelines.

Summary

These additions are to support the future addition of an ethernet driver for the STM32H563/H573 chips. This aims to add most of the necessary pre-processor defines and pin mappings necessary to port the ethernet driver from the stm32h7 to the stm32h5. The naming conventions mirror those in the h7 implementation, since these share ethernet peripheral IP.

A large number of the line changes in this PR are from removing unused comments in the pin map file.

Impact

Testing

After adding the files, no build errors occurred when building the nucleo-h563zi:nsh configuration.

Host OS: Ubuntu 24.04 on WSL 2 (Windows 11)
Compiler: arm-none-eabi-gcc (15:13.2.rel1-2) 13.2.1 20231009

Target:

  • Arch: STM32H5
  • Chip: STM32H563ZIT6U
  • Board: Nucleo-H563ZI
  • Config: nucleo-h563zi:nsh

@github-actions github-actions bot added Arch: arm Issues related to ARM (32-bit) architecture Board: arm labels Nov 7, 2024
@github-actions
Copy link

github-actions bot commented Nov 7, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions github-actions bot added the Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces. label Nov 7, 2024
@stbenn
Copy link
Contributor Author

stbenn commented Nov 7, 2024

Not quite sure why this could cause a failure in the pytest testing on the sabre-6quad. Is there some hidden dependency with the test that I am unaware of?

@xiaoxiang781216
Copy link
Contributor

Not quite sure why this could cause a failure in the pytest testing on the sabre-6quad. Is there some hidden dependency with the test that I am unaware of?

should be fixed by: apache/nuttx-apps#2829. let me retrigger the ci

@stbenn
Copy link
Contributor Author

stbenn commented Nov 8, 2024

@xiaoxiang781216 I see it is still failing, so I did some tests locally with the docker container. This is the log for arm-02 from the master commit this PR is based on (ed8bfdd) : docker-ed8bfdd2-arm02.log

And here is the log for arm-02 on this branch: eth-pr-arm02.log

I hope this can possibly help diagnose the problem!

Edit: Rebasing the PR to the newest master might help the issue. I rebased and pushed the branch

This commit adds files in preperation of adding ethernet drivers for the STM32H563 and Nucleo-H563ZI board.
It also modifies the pinmap to include ethernet pins (and cleaned up leftover comments from L5 file), as well as
add those pins to the board.h for the nucleo-h563zi.

Files added:
  - arch/arm/src/stm32h5/hardware/stm32_ethernet.h
  - arch/arm/src/stm32h5/hardware/stm32_sbs.h
    - Not fully implemented, just register necessary for ethernet driver.
@github-actions
Copy link

github-actions bot commented Nov 8, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@xiaoxiang781216
Copy link
Contributor

@xiaoxiang781216 I see it is still failing, so I did some tests locally with the docker container. This is the log for arm-02 from the master commit this PR is based on (ed8bfdd) : docker-ed8bfdd2-arm02.log

And here is the log for arm-02 on this branch: eth-pr-arm02.log

I hope this can possibly help diagnose the problem!

Edit: Rebasing the PR to the newest master might help the issue. I rebased and pushed the branch

fixed by #14705

@xiaoxiang781216 xiaoxiang781216 merged commit cd479f6 into apache:master Nov 9, 2024
@stbenn stbenn deleted the pr-eth-hw-files branch November 12, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch: arm Issues related to ARM (32-bit) architecture Board: arm Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants