stdio.h:Remove unnecessary header file #14697
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: File System
Contributor
Author
|
#14260 will fix this issues |
Contributor
Author
|
how to skip it, and pass ci? |
Contributor
let's ignore the false alarm, but the build break need be fixed. |
anchao
requested changes
Nov 13, 2024
xiaoxiang781216
previously approved these changes
Nov 14, 2024
jerpelea
previously approved these changes
Nov 14, 2024
Contributor
jerpelea
left a comment
jerpelea
left a comment
There was a problem hiding this comment.
please update the title since you are both adding and removing header files
Error: net/telnet.c:725:11: error: implicit declaration of function 'lib_free' [-Werror=implicit-function-declaration]
725 | lib_free(devpath);
| ^~~~~~~~
Error: /github/workspace/sources/nuttx/libs/libc/netdb/lib_netdb.h:117:1: error: unknown type name 'bool'
117 | bool convert_hostent(FAR const struct hostent_s *in,
| ^~~~
pthread_sigmask and pthread_kill just include <signal.h>
https://pubs.opengroup.org/onlinepubs/009695299/functions/pthread_sigmask.html
Signed-off-by: anjiahao <anjiahao@xiaomi.com>
Contributor
|
Will you revisit this @anjiahao1? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
remove unnecessary header file in stdio.h
Impact
Many compilation configs rely on removing redundant header files in stdio
Testing
build with sim:nsh