modlib:need add ctors to init_array and dtors to fini_array #14732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
github-actions
bot
added
the
Size: XS
Contributor
Author
|
@tmedicci Could you help me test this PR? Because I passed the test on qemu, I am not sure whether there is still a problem on the real device. Thank you very much |
1 task
xiaoxiang781216
approved these changes
Nov 12, 2024
anchao
requested changes
Nov 12, 2024
Contributor
anchao
left a comment
anchao
left a comment
There was a problem hiding this comment.
sync the script with other board
https://github.com/apache/nuttx/blob/master/boards/arm/stm32/axoloti/scripts/user-space.ld#L64-L65
Signed-off-by: anjiahao <anjiahao@xiaomi.com>
anchao
approved these changes
Nov 12, 2024
Contributor
|
Hi @anjiahao1 , it seems that this PR fixed the issue, but it's working only on QEMU. HW testing is failing (probably) due to #14625 (I'll check why QEMU and HW testing provide a different result here). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
modlib:need add ctors to init_array and dtors to fini_array
Impact
modlib
Testing
esp32 with qemu run module, and pass it