-
Notifications
You must be signed in to change notification settings - Fork 1.5k
lib_pathbuffer: change nxmutex -> spinlock #14799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib_pathbuffer: change nxmutex -> spinlock #14799
Conversation
dd81ba1 to
a986ff4
Compare
|
[Experimental Bot, please feedback here] Yes, this PR mostly meets the NuttX requirements, but could be improved. Here's what's good:
Here's what needs improvement:
By adding these details, the PR will be much stronger and easier to review. |
Is this exception caused because assert is called within an interrupt? |
lib_get_pathbuffer is used in many places, so it's better to the interrupt safe. |
|
LGTM |
a986ff4 to
7ceaab7
Compare
Summary:
_assert
|
->dump_fatal_info
|
->dump_tasks
|
->dump_filelist
|
->files_dumplist
|
->lib_get_pathbuffer
|
->nxmutex_lock <-- hold mutex on assert will trigger an nested exception
Signed-off-by: chenrun1 <chenrun1@xiaomi.com>
7ceaab7 to
f811637
Compare
Summary:
Summary
Change nxmutex to spinlock to fix bug:
Impact
Is a new feature added?: NO
Impact on build: NO
Impact on hardware: NO, this change does not specifically target any particular hardware architectures or boards.
Impact on documentation: NO,This patch does not introduce any new features
Impact on compatibility: This implementation aims to be backward compatible. No existing functionality is expected to be broken.
Testing
Build Host(s): Linux x86
Test cases based on local qemu environment passed