-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[ci] platforms: added toolchains #14934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add toolchains for macOS on Apple Intel xtensa-esp32s2 xtensa-esp32s3 add toolchains for macOS on Apple Silicon xtensa-esp32s2 xtensa-esp32s3 add install for ubuntu.sh xtensa-esp32s2 xtensa-esp32s3 add install for linux.sh xtensa-esp32s2 xtensa-esp32s3
|
[Experimental Bot, please feedback here] This PR appears to mostly meet the NuttX requirements, but it's missing some crucial information and could be significantly improved. Strengths:
Weaknesses:
Recommendations for Improvement:
By addressing these weaknesses, the PR will be much stronger and easier for reviewers to evaluate. Clear, concise, and complete information is essential for a smooth and efficient review process. |
lupyuen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @simbit18! :-)
lupyuen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK on macOS M2 Pro thanks!
https://gist.github.com/lupyuen/6b51580a5df6d86872b529b9e0174626
$ git clone https://github.com/simbit18/nuttx --branch simbit18-darwin
$ nuttx/tools/testbuild.sh -A -R -j 12 -e '-Wno-cpp -Werror' testlist/xtensa-02.dat
Configuration/Tool: esp32s2-saola-1/spiflash
Building NuttX...
Normalize esp32s2-saola-1/spiflash
Previously xtensa-02 fails with "xtensa-esp32s2-elf-gcc: command not found"
|
Hmmm I can't recall why, perhaps because I copied from the GitHub CI Logs for macOS? |
|
now if you use it it saves minutes of build time |
|
Yep that should be helpful for normal builds. For macOS Build Farm: We're replicating the same Build Environment as GitHub Actions, so we'll stick to the current settings. Thanks! |
|
I did not put option -S on github for macOS because it does not have xtensa-01 and xtensa-02 nuttx/.github/workflows/build.yml Line 205 in e69903c
|
Summary
add toolchains for macOS on Apple Intel
xtensa-esp32s2
xtensa-esp32s3
add toolchains for macOS on Apple Silicon
xtensa-esp32s2
xtensa-esp32s3
add install for ubuntu.sh
xtensa-esp32s2
xtensa-esp32s3
add install for linux.sh
xtensa-esp32s2
xtensa-esp32s3
Impact
Impact on user: No changes to user-facing functionality
Impact on build: Build process remains the same
Testing
github macos-13 and macos-14
macOS on Apple Silicon and Intel esp32s3
macOS on Apple Silicon and Intel esp32s2