Skip to content

Conversation

@hujun260
Copy link
Contributor

Summary

remove redundant scheduling records
reason:
Since the scheduling records have already been moved to the interrupt exit in this submission, we need to delete the original records' locations. This commit fixes the regression from #13651

Impact

scheduling records

Testing

ci ostest

reason:
Since the scheduling records have already been moved to the interrupt exit in this submission,
we need to delete the original records' locations.
This commit fixes the regression from apache#13651

Signed-off-by: hujun5 <hujun5@xiaomi.com>
@github-actions github-actions bot added Arch: arm Issues related to ARM (32-bit) architecture Arch: arm64 Issues related to ARM64 (64-bit) architecture Arch: x86_64 Issues related to the x86_64 architecture Size: S The size of the change in this PR is small labels Nov 28, 2024
@nuttxpr
Copy link

nuttxpr commented Nov 28, 2024

[Experimental Bot, please feedback here]

No, this PR does not fully meet the NuttX requirements. While it provides a summary and testing information, it lacks crucial details.

Here's what's missing:

  • Summary: Needs more detail. How does removing the redundant records work? What specific code is being removed? The provided summary is more of a justification.
  • Impact: This section is severely lacking. It needs to address all the points listed in the template (user impact, build impact, hardware impact, documentation, security, compatibility). Simply stating "scheduling records" doesn't explain the impact. Even if the answer is "NO" for most of them, it should be explicitly stated.
  • Testing: While CI testing is mentioned, providing actual log snippets demonstrating the issue before the change and the corrected behavior after the change is essential. "ci ostest" isn't sufficient. Also, specifying the Build Host and Target details is required.

In short, the PR needs to be significantly expanded to meet the requirements. Each section in the template needs to be properly addressed, even if the answer is "NO." More detail is needed in the summary and, crucially, actual testing logs must be included.

@acassis
Copy link
Contributor

acassis commented Nov 28, 2024

@masayuki2009 please verify if this PR fix the QEMU regression

@xiaoxiang781216 xiaoxiang781216 merged commit 0bba53c into apache:master Nov 28, 2024
27 checks passed
@hujun260 hujun260 deleted the apache_36 branch December 1, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch: arm Issues related to ARM (32-bit) architecture Arch: arm64 Issues related to ARM64 (64-bit) architecture Arch: x86_64 Issues related to the x86_64 architecture Size: S The size of the change in this PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants