-
Notifications
You must be signed in to change notification settings - Fork 1.5k
make arm-v6/7/8m compatible with signal delivery inside irq handler #15048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[Experimental Bot, please feedback here] This PR appears to mostly meet the NuttX requirements, but is missing some crucial information. Here's a breakdown: Strengths:
Weaknesses:
Recommendation: Before merging, the PR author should address the missing information:
By providing this missing information, the PR will better meet the NuttX requirements and facilitate a smoother review process. |
1 task
Nested irq possible cause readytorun not match with regs Signed-off-by: buxiasen <buxiasen@xiaomi.com>
xiaoxiang781216
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
after #13606 , up_schedule_sigaction behavior got error when exception direct, as we did not save the last regs to speed up.
first issue is smp sig delivery,
#14363
after chip specific vectors, still issue on sig deliver inside irq handler.
#14514
As we always trigger a pendsv to do context switch, should also do signal requrements context switch inside pendsv handler.
test-case in mps2 qemu:
apache/nuttx-apps#2877
after this patch, the custom vector table for arm-v6/7/8m smp, no longer required
Impact
now compatible with send signal in irq handler。
Testing
CI-test,
local qemu mps2(by apps cmocka case),
spersense(pass ostest after revert ARCH_HAVE_CUSTOM_VECTORS in ARCH_CHIP_CXD56XX)