Skip to content

Conversation

@hujun260
Copy link
Contributor

Summary

modifyreg[8|32]: use small lock in modifyreg[8|32]
reason:
We would like to replace the big lock with a small lock.

Impact

modifyreg

Testing

ci

reason:
We would like to replace the big lock with a small lock.

Signed-off-by: hujun5 <hujun5@xiaomi.com>
@github-actions github-actions bot added Arch: arm Issues related to ARM (32-bit) architecture Arch: arm64 Issues related to ARM64 (64-bit) architecture Arch: avr Issues related to all AVR(8-bit or 32-bit) architectures Arch: ceva Issues related to CEVA architecture Arch: hc Issues related to HC architecture Arch: mips Issues related to the MIPS architecture Arch: openrisc Issues related to the OpenRISC architecture Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: sparc Issues related to the SPARC architecture Arch: x86 Issues related to the x86 architecture Arch: x86_64 Issues related to the x86_64 architecture Arch: xtensa Issues related to the Xtensa architecture Arch: z80 Issues related to the Z80 architecture Size: M The size of the change in this PR is medium labels Dec 19, 2024
@nuttxpr
Copy link

nuttxpr commented Dec 19, 2024

[Experimental Bot, please feedback here]

No, this PR does not fully meet the NuttX requirements. The summary is insufficiently detailed. It doesn't explain what modifyreg is, how the lock change works (e.g., what type of small lock is used), or why a smaller lock is beneficial (e.g., performance improvement). It also lacks links to any related issues.

The impact section is also incomplete. It only mentions modifyreg but doesn't properly address any of the required impact categories (user, build, hardware, documentation, security, compatibility). Simply stating "NO" or "YES" is not enough; a description is required for each "YES."

Finally, the testing section is inadequate. It provides no details on the build host or target environment, and the "testing logs" are empty. Actual logs demonstrating the change's behavior (before and after) are necessary.

@xiaoxiang781216 xiaoxiang781216 merged commit ecdff65 into apache:master Dec 19, 2024
27 checks passed
@hujun260 hujun260 deleted the apache39 branch February 5, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch: arm Issues related to ARM (32-bit) architecture Arch: arm64 Issues related to ARM64 (64-bit) architecture Arch: avr Issues related to all AVR(8-bit or 32-bit) architectures Arch: ceva Issues related to CEVA architecture Arch: hc Issues related to HC architecture Arch: mips Issues related to the MIPS architecture Arch: openrisc Issues related to the OpenRISC architecture Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: sparc Issues related to the SPARC architecture Arch: x86 Issues related to the x86 architecture Arch: x86_64 Issues related to the x86_64 architecture Arch: xtensa Issues related to the Xtensa architecture Arch: z80 Issues related to the Z80 architecture Size: M The size of the change in this PR is medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants