-
Notifications
You must be signed in to change notification settings - Fork 1.5k
imx9_flexcan: use small lock in arch/arm/src/imx9/imx9_flexcan.c #15290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. While it provides a basic summary and identifies the impacted area, it lacks crucial details. Here's a breakdown of what's missing:
In short, the PR needs to be significantly more detailed to meet the NuttX requirements. It needs to explain the change thoroughly, analyze its impact comprehensively, and provide concrete evidence of testing. |
f136b98 to
e51a0ba
Compare
reason: We would like to replace the big lock with a small lock. Signed-off-by: hujun5 <hujun5@xiaomi.com>
chip/stm32_gpio.c:44:11: note: '#pragma message: CONFIG_STM32_USE_LEGACY_PINMAP will be deprecated migrate board.h see tools/stm32_pinmap_tool.py'
44 | # pragma message "CONFIG_STM32_USE_LEGACY_PINMAP will be deprecated migrate board.h see tools/stm32_pinmap_tool.py"
| ^~~~~~~
CC: pthread/pthread_mutexconsistent.c In file included from chip/stm32_flash.c:40:
chip/stm32f20xxf40xx_flash.c:53:4: warning: #warning "Default Flash Configuration Used - See Override Flash Size Designator" [-Wcpp]
53 | # warning "Default Flash Configuration Used - See Override Flash Size Designator"
| ^~~~~~~
board/stm32_ethernet.c:84:19: warning: 'g_phy_lock' defined but not used [-Wunused-variable]
84 | static spinlock_t g_phy_lock = SP_UNLOCKED;
| ^~~~~~~~~~
LD: nuttx
Signed-off-by: hujun5 <hujun5@xiaomi.com>
Summary
imx9_flexcan: use small lock in arch/arm/src/imx9/imx9_flexcan.c
reason:
We would like to replace the big lock with a small lock.
Impact
imx9_flexcan
Testing
ci