-
Notifications
You must be signed in to change notification settings - Fork 1.5k
nxgdb/fs: simpifiy inode print and add more command options #15742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Instead of storing it to self Signed-off-by: xuxingliang <xuxingliang@xiaomi.com>
Use Inode.__repr__ for print and use single line for all information.
Add 'verbose' and 'nodetype' option to show more details and only print specifiy node type like PIPE.
Add / to name for pseudodir.
Catch memory error when accessing node element.
E.g.
(gdb) foreach inode --nodetype pipe
├── run/ 0x41a27a50 PSEUDODIR
│ ├── bt:bluetoothCS1fd26 0x4530c510 PIPE
│ ├── bt:bluetoothCS20 0x42daae40 PIPE
│ ├── socketpair0x457fd2e0SC20540 0x44ea27b0 PIPE
│ └── tmp/ 0x42dd7cf0 PSEUDODIR
│ │ └── usock/ 0x42dd6c10 PSEUDODIR
│ │ └── speech.usockHD 0x42dc8270 PIPE
│ ├── central_lite.socketCS5e 0x42e1e7b0 PIPE
│ ├── central_service_lite.socketSC86 0x432ee6d0 PIPE
│ │ └── usock/ 0x43d6ed60 PSEUDODIR
│ │ └── speech.usockHD 0x43da2ba0 PIPE
│ ├── uv-feature-sockSC8d 0x43540430 PIPE
│ ├── uv-miot-sockCS54 0x42e272e0 PIPE
│ └── uv-miot-sockSC54 0x42e270b0 PIPE
Signed-off-by: xuxingliang <xuxingliang@xiaomi.com>
|
[Experimental Bot, please feedback here] This PR description, while providing some information, is insufficient for a proper NuttX review. Here's a breakdown of its shortcomings and how to improve it: Summary - Needs More Detail:
Impact - Insufficient Detail:
Testing - Woefully Inadequate:
Revised PR Description (Example): SummaryThis PR improves the
Additionally, pseudo-directories are now visually distinguished by appending a Related Issue: [NuttX #1234](replace with actual issue if applicable) Impact
TestingI confirm that changes are verified on my local setup and work as intended:
Testing logs before change: Testing logs after change: By providing more detail and context, you make it easier for reviewers to understand and approve your PR. Remember to replace the placeholders with your actual information. |
Note: Please adhere to Contributing Guidelines.
Summary
Impact
New command option and code refactor.
Testing
Tested locally with a coredump.