sched: Fix typo on queue.h #16340
Closed
sched: Fix typo on queue.h #16340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This typo was in the dq_insert_mid() macro introduced in the apache#13616 This issue was found by Serg Podtynnyi <serg@podtynnyi.com> Signed-off-by: Alan Carvalho de Assis <acassis@gmail.com>
github-actions
bot
added
Area: OS Components
cederom
approved these changes
May 8, 2025
Contributor
Author
|
@hujun260 could you please review? As Serg noticed the issue wasn't evident before because "prev" was defined in other context and used from there. But we don't know what side effect this typo could cause in the kernel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This typo was in the dq_insert_mid() macro introduced in the #13616
This issue was found by Serg Podtynnyi serg@podtynnyi.com
Impact
Fix
Testing
Build