Skip to content

Conversation

@jingfei195887
Copy link
Contributor

@jingfei195887 jingfei195887 commented Jul 17, 2025

Summary

This is a supplement to the patch: drivers/fs:Always use register_mtddriver() to register the MTD device1936126210a56b6d1b033d6d940669413dd6e1b0

Due to the automatic wrapping of MTD devices during the open() process, the legacy registration methods
ftl_initialize() are no longer required for MTD device registration for user code .
So I have adjusted the registration method for MTD devices in nuttx/boards, replacing the previous approach from using ftl_initialize() to register_mtddriver().

@jingfei195887 jingfei195887 marked this pull request as draft July 17, 2025 16:53
@github-actions github-actions bot added the Size: M The size of the change in this PR is medium label Jul 18, 2025
@jingfei195887 jingfei195887 marked this pull request as ready for review July 18, 2025 03:08
@jingfei195887 jingfei195887 force-pushed the mtd_optimize branch 2 times, most recently from d0e01f6 to 29e3905 Compare July 18, 2025 06:10
@jingfei195887
Copy link
Contributor Author

@xiaoxiang781216 it seems xtensa-01 of CI can not worked . I bought a esp32 board but still have no time for test, maybe in this weekend

@fdcavalcanti
Copy link
Contributor

@xiaoxiang781216 it seems xtensa-01 of CI can not worked . I bought a esp32 board but still have no time for test, maybe in this weekend

If the issue is nxlooper example, we are looking into. Fix is coming soon.

@xiaoxiang781216
Copy link
Contributor

@xiaoxiang781216 it seems xtensa-01 of CI can not worked . I bought a esp32 board but still have no time for test, maybe in this weekend

@fdcavalcanti do you find the cause of xtensa ci break?

@fdcavalcanti
Copy link
Contributor

@jingfei195887 can you rebase please? CI should pass now.

@jingfei195887
Copy link
Contributor Author

@jingfei195887 can you rebase please? CI should pass now.

yes. do it now! Thanks for the help

… (patch2)

This is a supplement to the patch:1936126210a56b6d1b033d6d940669413dd6e1b0

Due to the automatic wrapping of MTD devices during the
open() process, the legacy registration methods
ftl_initialize() and bchdev_register() are no longer
required for MTD device registration for user code.

So we have adjusted the registration method for MTD devices
in nuttx/boards, replacing the previous approach using
ftl_initialize()  with register_mtddriver().
@fdcavalcanti fdcavalcanti merged commit db54331 into apache:master Jul 21, 2025
39 checks passed
xiaoxiang781216 added a commit to xiaoxiang781216/incubator-nuttx that referenced this pull request Jul 22, 2025
since ftl_initialize isn't used anymore after:
apache#16642
apache#16738

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
xiaoxiang781216 added a commit to xiaoxiang781216/incubator-nuttx that referenced this pull request Jul 29, 2025
since ftl_initialize isn't used anymore after:
apache#16642
apache#16738

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
xiaoxiang781216 added a commit to xiaoxiang781216/incubator-nuttx that referenced this pull request Jul 30, 2025
since ftl_initialize isn't used anymore after:
apache#16642
apache#16738

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Board: arm Board: mips Board: risc-v Board: xtensa Size: L The size of the change in this PR is large Size: M The size of the change in this PR is medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants