Skip to content

net/can: add write buffer to support nonblock send #17435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaoxiang781216 merged 5 commits into from
Dec 15, 2025
Merged

net/can: add write buffer to support nonblock send #17435

xiaoxiang781216 merged 5 commits into from
Dec 15, 2025

Conversation

@zhhyu7
Copy link
Contributor

@zhhyu7 zhhyu7 commented Dec 5, 2025

Summary

add write buffer to support nonblock send, and improve the processing of some code.

Impact

Partial return values of can socket bind,
The sending method of can_sendmsg.

Testing

INFINEON board.
After the can socket is bound to the CAN network card, data is sent and received in nonblock mode.

@github-actions github-actions bot added Area: Networking Effects networking subsystem Size: L The size of the change in this PR is large labels Dec 5, 2025
@acassis
Copy link
Contributor

acassis commented Dec 5, 2025

@simbit18 seems like github is having difficulties:

error: failed retrieving file 'vim-9.1.1623-1-x86_64.pkg.tar.zst.sig' from ftp2.osuosl.org : Operation too slow. Less than 1 bytes/sec transferred the last 10 seconds
error: failed retrieving file 'ninja-1.13.1-1-x86_64.pkg.tar.zst' from mirror.msys2.org : Operation too slow. Less than 1 bytes/sec transferred the last 10 seconds
warning: failed to retrieve some files
error: failed to commit transaction (unexpected error)
Errors occurred, no packages were upgraded.
Error: The process 'C:\Windows\system32\cmd.exe' failed with exit code 1

@simbit18
Copy link
Contributor

simbit18 commented Dec 5, 2025

Hi @acassis , let's wait for all the jobs to finish running and then restart the msys2 job.

@acassis
Copy link
Contributor

acassis commented Dec 5, 2025

Hi @acassis , let's wait for all the jobs to finish running and then restart the msys2 job.

Question: is there some way to avoid download the source code packages all the time? Maybe adding it to the docker machine directly?

@simbit18
Copy link
Contributor

simbit18 commented Dec 5, 2025

@acassis , previously the cache was enabled for GitHub Action to setup MSYS2, but to avoid closing the NuttX repository, we had to make some cuts. :)
#14618
#14909
Now it is only available on our Mirror for msys2 and macos
https://github.com/NuttX/nuttx/actions/caches

@acassis
Copy link
Contributor

acassis commented Dec 5, 2025 •
edited
Loading

@acassis , previously the cache was enabled for GitHub Action to setup MSYS2, but to avoid closing the NuttX repository, we had to make some cuts. :) #14618 #14909 Now it is only available on our Mirror for msys2 and macos https://github.com/NuttX/nuttx/actions/caches

Thank you @simbit18 ! I don't understand why ASF was limiting our job runners, but they keep the same amount for all projects, even projects that are dead.

xiaoxiang781216
xiaoxiang781216 previously approved these changes Dec 6, 2025
View reviewed changes
acassis
acassis previously requested changes Dec 6, 2025
View reviewed changes
Copy link
Contributor

@acassis acassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhhyu7 new feature without Documentation, please add https://nuttx.apache.org/docs/latest/components/drivers/character/can.html

@acassis
Copy link
Contributor

acassis commented Dec 6, 2025

@zhhyu7 I noticed that the CAN documentation starts with wrong information: "NuttX supports only a very low-level CAN driver.", could you please fix it when updating the RST file?

@zhhyu7
Copy link
Contributor Author

zhhyu7 commented Dec 8, 2025

@zhhyu7 I noticed that the CAN documentation starts with wrong information: "NuttX supports only a very low-level CAN driver.", could you please fix it when updating the RST file?

OK.

@zhhyu7 zhhyu7 requested a review from anchao as a code owner December 8, 2025 04:22
@github-actions github-actions bot added the Area: Documentation Improvements or additions to documentation label Dec 8, 2025
xiaoxiang781216
xiaoxiang781216 previously approved these changes Dec 8, 2025
View reviewed changes
anchao
anchao previously approved these changes Dec 8, 2025
View reviewed changes
simbit18
simbit18 previously approved these changes Dec 9, 2025
View reviewed changes
@xiaoxiang781216
Copy link
Contributor

xiaoxiang781216 commented Dec 10, 2025

@zhhyu7 new feature without Documentation, please add https://nuttx.apache.org/docs/latest/components/drivers/character/can.html

@acassis please review again.

acassis
acassis reviewed Dec 10, 2025
View reviewed changes
@acassis
Copy link
Contributor

acassis commented Dec 10, 2025

Really good Documentation @zhhyu7 !!! Thank you for doing it!

@acassis acassis dismissed their stale review December 10, 2025 15:59

Documentation already added, just need some modifications

zhhyu7 and others added 5 commits December 11, 2025 12:05
@zhhyu7
net/can: return -ENODEV if the device is not found when bind
5e06d9e 
correction return value

Signed-off-by: zhanghongyu <zhanghongyu@xiaomi.com>
@zhhyu7
net/can: support can receive packets from all can devices
f4d8e66 
after the socket calls bind with ifindex is 0, it can receive packets
from all can devices

Signed-off-by: zhanghongyu <zhanghongyu@xiaomi.com>
@jwang12340 @zhhyu7
net/can: add write buffer to support nonblock send
de32f9f 
The sending of can socket can support more scenarios

Signed-off-by: wangjinjing1 <wangjinjing1@xiaomi.com>
@jwang12340 @zhhyu7
net/can,udp,tcp: add sem destroy for udp/tcp sndsem;
4076bcb 
standardize the usage of semphore

Signed-off-by: wangjinjing1 <wangjinjing1@xiaomi.com>
@zhhyu7
net/can: fix possible IOB resource leak when can close
2a70366 
If there is data in readahead, it needs to be released; otherwise,
it will cause the leakage of IOB resources

Signed-off-by: zhanghongyu <zhanghongyu@xiaomi.com>
@zhhyu7 zhhyu7 dismissed stale reviews from simbit18, anchao, and xiaoxiang781216 via 2a70366 December 11, 2025 04:06
@xiaoxiang781216 xiaoxiang781216 merged commit 2b092ad into apache:master Dec 15, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acassis acassis acassis left review comments

@jerpelea jerpelea jerpelea approved these changes

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

@anchao anchao anchao left review comments

@simbit18 simbit18 simbit18 left review comments

@Donny9 Donny9 Awaiting requested review from Donny9 Donny9 is a code owner

@raiden00pl raiden00pl Awaiting requested review from raiden00pl raiden00pl is a code owner

@yamt yamt Awaiting requested review from yamt yamt is a code owner

@Ouss4 Ouss4 Awaiting requested review from Ouss4 Ouss4 is a code owner

@btashton btashton Awaiting requested review from btashton btashton is a code owner

Assignees

No one assigned

Labels

Area: Documentation Improvements or additions to documentation Area: Networking Effects networking subsystem Size: L The size of the change in this PR is large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zhhyu7 @acassis @simbit18 @xiaoxiang781216 @anchao @jerpelea @jwang12340