Revert "macOS support for sim" #180
Conversation
This reverts commit 4174c81.
This reverts commit b2b84cb.
This reverts commit b5573c5.
This reverts commit b879b9b.
This reverts commit cc90d58.
This reverts commit 298c2e5.
This reverts commit 39bd9ff.
This reverts commit b1678d0.
This reverts commit 5c6cca8.
This reverts commit 69a8b97.
This reverts commit aa8aadf.
This reverts commit 431317e.
|
How about let @yamt provide the new PR instead reverting the whole patchset? |
|
This should be closed, right? It was merged prematurely. For complex changes.. ESPECIALLY changes involving the build system, we must wait for comments. Committing build system change blindly is almost always fatal. We are waiting for the updates from the author now, right? So this should be closed. |
|
I am sorry for accidentally merging this one |
|
we can revert it and wait to get the fixes or we can merge my revert and wait to a new PR |
|
Don't worry about it. We appreciate all of your help. We all sometimes make the decision that we would later do differently. I think I have done many like that and I usually hear about it too. I think it would be simpler to just add the fixes rather than reverting and reapplying the whole thing, But we need make sure that everyone understands how we are going to proceed and make sure that fixes will actually happen. |
|
"we can revert it and wait to get the fixes or we can merge my revert and wait to a new PR"-- less turmoil if we can wait. I propose that if nothing happens in 24 hours, we go ahead and revert. I can do the merge for you then. |
|
@jerpelea Should the |
|
done ! |
5 participants
Reverts #179