Cc26x2: Fix syntax error and nxstyle issues #2179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arch/arm/src/tiva/hardware/cc13x2_cc26x2/cc13x2_cc26x2_adi3_refsys.h:
* Fix nxstyle errors.
arch/arm/src/tiva/hardware/cc13x2_cc26x2/cc13x2_cc26x2_adi3_refsys.h:
* Fix syntax error. The define ADI3_REFSYS_DCDCCTL0_VDDR_TRIM_MIN
had an unintentional comment closing "*/" in the middle of its
name.
extinguish
added a commit
to extinguish/nuttx
that referenced
this pull request
Aug 10, 2024
CC: assert/lib_assert.c [asarm] (error apache#2179) modlib/modlib_globals.S 61: unexpected token type (char) encountered; expected type (identifier) .size \ globalNames , . - \ globalNames --------^ [asarm] (error apache#2179) modlib/modlib_globals.S 67: unexpected token type (char) encountered; expected type (identifier) .size \ nglobals , . - \ nglobals --------^ [asarm] (error apache#2179) modlib/modlib_globals.S 72: unexpected token type (char) encountered; expected type (identifier) .size \ global_table , . - \ global_table --------^ Signed-off-by: guoshichao <guoshichao@xiaomi.com>
extinguish
added a commit
to extinguish/nuttx
that referenced
this pull request
Aug 11, 2024
CC: assert/lib_assert.c [asarm] (error apache#2179) modlib/modlib_globals.S 61: unexpected token type (char) encountered; expected type (identifier) .size \ globalNames , . - \ globalNames --------^ [asarm] (error apache#2179) modlib/modlib_globals.S 67: unexpected token type (char) encountered; expected type (identifier) .size \ nglobals , . - \ nglobals --------^ [asarm] (error apache#2179) modlib/modlib_globals.S 72: unexpected token type (char) encountered; expected type (identifier) .size \ global_table , . - \ global_table --------^ Signed-off-by: guoshichao <guoshichao@xiaomi.com>
acassis
pushed a commit
that referenced
this pull request
Aug 11, 2024
CC: assert/lib_assert.c [asarm] (error #2179) modlib/modlib_globals.S 61: unexpected token type (char) encountered; expected type (identifier) .size \ globalNames , . - \ globalNames --------^ [asarm] (error #2179) modlib/modlib_globals.S 67: unexpected token type (char) encountered; expected type (identifier) .size \ nglobals , . - \ nglobals --------^ [asarm] (error #2179) modlib/modlib_globals.S 72: unexpected token type (char) encountered; expected type (identifier) .size \ global_table , . - \ global_table --------^ Signed-off-by: guoshichao <guoshichao@xiaomi.com>
xiezhanpeng2025
added a commit
to xiezhanpeng2025/nuttx
that referenced
this pull request
Nov 13, 2025
The GHS compiler uses different .macro syntax. Without this change, the GHS compiler reports error like: [asarm] (error apache#2014) nuttx/arch/arm/src/armv8-r/arm_vectors.S 155: expected a register vstmdb \ out ! , { s0 - s31 } ---------^ And: [asarm] (error apache#2179) nuttx/arch/arm/src/armv8-r/arm_vectors.S 141: unexpected token type (comma) encountered; expected type (char) .macro savefpu , out , tmp -----------------^ Co-authored-by: Chengdong Wang <wangchengdong@lixiang.com> Signed-off-by: xiezhanpeng3 <xiezhanpeng3@lixiang.com>
xiezhanpeng2025
added a commit
to xiezhanpeng2025/nuttx
that referenced
this pull request
Nov 13, 2025
The GHS compiler uses different .macro syntax. Without this change, the GHS compiler reports error like: [asarm] (error apache#2014) nuttx/arch/arm/src/armv8-r/arm_vectors.S 155: expected a register vstmdb \ out ! , { s0 - s31 } ---------^ And: [asarm] (error apache#2179) nuttx/arch/arm/src/armv8-r/arm_vectors.S 141: unexpected token type (comma) encountered; expected type (char) .macro savefpu , out , tmp -----------------^ Co-authored-by: Chengdong Wang <wangchengdong@lixiang.com> Signed-off-by: xiezhanpeng3 <xiezhanpeng3@lixiang.com>
xiezhanpeng2025
added a commit
to xiezhanpeng2025/nuttx
that referenced
this pull request
Nov 13, 2025
The GHS compiler uses different .macro syntax. Without this change, the GHS compiler reports error like: [asarm] (error apache#2014) nuttx/arch/arm/src/armv8-r/arm_vectors.S 155: expected a register vstmdb \ out ! , { s0 - s31 } ---------^ And: [asarm] (error apache#2179) nuttx/arch/arm/src/armv8-r/arm_vectors.S 141: unexpected token type (comma) encountered; expected type (char) .macro savefpu , out , tmp -----------------^ Co-authored-by: Chengdong Wang <wangchengdong@lixiang.com> Signed-off-by: xiezhanpeng3 <xiezhanpeng3@lixiang.com>
xiezhanpeng2025
added a commit
to xiezhanpeng2025/nuttx
that referenced
this pull request
Nov 13, 2025
The GHS compiler uses different .macro syntax. Without this change, the GHS compiler reports error like: [asarm] (error apache#2014) nuttx/arch/arm/src/armv8-r/arm_vectors.S 155: expected a register vstmdb \ out ! , { s0 - s31 } ---------^ And: [asarm] (error apache#2179) nuttx/arch/arm/src/armv8-r/arm_vectors.S 141: unexpected token type (comma) encountered; expected type (char) .macro savefpu , out , tmp -----------------^ Co-authored-by: Chengdong Wang <wangchengdong@lixiang.com> Signed-off-by: xiezhanpeng3 <xiezhanpeng3@lixiang.com>
xiaoxiang781216
pushed a commit
that referenced
this pull request
Nov 13, 2025
The GHS compiler uses different .macro syntax. Without this change, the GHS compiler reports error like: [asarm] (error #2014) nuttx/arch/arm/src/armv8-r/arm_vectors.S 155: expected a register vstmdb \ out ! , { s0 - s31 } ---------^ And: [asarm] (error #2179) nuttx/arch/arm/src/armv8-r/arm_vectors.S 141: unexpected token type (comma) encountered; expected type (char) .macro savefpu , out , tmp -----------------^ Co-authored-by: Chengdong Wang <wangchengdong@lixiang.com> Signed-off-by: xiezhanpeng3 <xiezhanpeng3@lixiang.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
arch/arm/src/tiva/hardware/cc13x2_cc26x2/cc13x2_cc26x2_adi3_refsys.h:
Impact
Removes nxstyle and syntax error. Note this architecture has known breakage. That will be addressed in a later PR.
Testing
nxstyle and visual inspection