Skip to content

Conversation

@masayuki2009
Copy link
Contributor

Summary

  • This PR fixes style warnings and compile erros in arm_l2cc_pl310.c and l2cc_pl310.h
  • Then I applied the code to the sabre-6quad board
  • Also, I removed unnecessary d-cache operation to make boot fast

Impact

  • armv7-a with L2CC
  • sabre-6quad:nsh and sabre-6quad:smp

Testing

  • Tested with sabre-6quad:smp (QEMU and dev board)
  • Tested with sabre-6quad:nsh (QEMU and dev board)

Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>>
Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
Summary:
- This commit adds L2CC to nsh/defconfig
- Also adds EXAMPLES_HELLO, TESTING_GETPRIME and TESTING_OSTEST

Impact:
- sabre-6quad:nsh only

Testing:
- Tested with both QEMU and dev board

Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
Summary:
- This commit adds L2CC to smp/defconfig
- Also adds CLOCK_MONOTONIC

Impact:
- sabre-6quad:smp only

Testing:
- Tested with both QEMU and dev board

Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
Summary:
- Remove unnecessary d-cache operation to make boot fast

Impact:
- armv7-a SMP only

Testing:
- Tested with sabre-6quad:smp (QEMU and dev board)

Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
@masayuki2009
Copy link
Contributor Author

Hmmm, the following error happenned but the error does not relate to this PR.

====================================================================================
Configuration/Tool: stm32f429i-disco/nxwm,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Disabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
  Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
  Building NuttX...
src/chexcalculator.cxx: In member function 'void NxWM::CHexCalculator::updateText()':
Error: src/chexcalculator.cxx:676:38: error: expected ')' before 'PRI64X'
  676 |       std::snprintf(buffer, 24, "%16" PRI64X, m_accum);
      |                    ~                 ^~~~~~~
      |                                      )
Error: src/chexcalculator.cxx:680:36: error: expected ')' before 'PRI64d'
  680 |       std::snprintf(buffer, 24, "%" PRI64d, m_accum);
      |                    ~               ^~~~~~~
      |                                    )

@yamt
Copy link
Contributor

yamt commented Nov 16, 2020

@masayuki2009
Copy link
Contributor Author

@jerpelea
Copy link
Contributor

LGTM

@xiaoxiang781216 xiaoxiang781216 merged commit 13f3f84 into apache:master Nov 16, 2020
@masayuki2009
Copy link
Contributor Author

@btashton
Could you backport this PR to the 10.0 branch?

@btashton
Copy link
Contributor

@btashton
Could you backport this PR to the 10.0 branch?

Sure I'll go through these tonight there are a few more as well. I already did this for these two, but if you add the label they will show up in my query so I won't miss them.

@masayuki2009
Copy link
Contributor Author

@btashton
Could you backport this PR to the 10.0 branch?

Sure I'll go through these tonight there are a few more as well. I already did this for these two, but if you add the label they will show up in my query so I won't miss them.

@btashton
Ok, got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants