CI: Allow builds to pass even if final artifact upload fails #2592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are seeing higher cases of artifact upload failures in github. Other projects are also seeing this as has been reported at actions/upload-artifact#116 There is a fix that was just merged in the base library: actions/toolkit#675 So Hopefully we can revert this before too long. Signed-off-by: Brennan Ashton <bashton@brennanashton.com>
xiaoxiang781216
approved these changes
Dec 23, 2020
jerpelea
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are seeing higher cases of artifact upload failures
in github. Other projects are also seeing this as has been
reported at actions/upload-artifact#116
There is a fix that was just merged in the base library:
actions/toolkit#675
So Hopefully we can revert this before too long.
Signed-off-by: Brennan Ashton bashton@brennanashton.com
Impact
Final build artifacts might not be uploaded, but this will not cause a build to fail. I am using these build artifacts for analysis and testing so I would like to keep them enabled if possible.