Skip to content

net: socket: Enable parameter check (addr and addrlen) in getsockname.c #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaoxiang781216 merged 1 commit into from
Feb 21, 2020
Merged

net: socket: Enable parameter check (addr and addrlen) in getsockname.c #345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions net/socket/getsockname.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,16 +101,12 @@ int psock_getsockname(FAR struct socket *psock, FAR struct sockaddr *addr,
return -EBADF;
}

/* Some sanity checking... Shouldn't need this on a buckled up embedded
* system (?)
*/
/* Some sanity checking... */

#ifdef CONFIG_DEBUG_FEATURES
if (addr == NULL || *addrlen <= 0)
if (addr == NULL || addrlen == NULL)
{
return -EINVAL;
}
#endif

/* Let the address family's send() method handle the operation */

Expand Down