NFS bug fix and improvement #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the check just waste cpu cycle since nobody will set nm_mounted to false, and remove the unused fields(nm_mounted and n_flags) and related flags too Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com> Change-Id: I0e35e28347f26e29e77a8eeb668a5b9c38a746ef
and other minor issue(unused, typo, duplication, alignment...) Change-Id: I72b0161e05e1a40f5347ff62294d0fc9ac0b0927 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
and remove the unused arguments from function Change-Id: Ie6d45444dfbe70ff806d2360260f551081c9d2e8 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
and fix warning:
nfs/nfs.h:59:28: warning: large integer implicitly truncated to unsigned type [-Woverflow]
#define NFS_TIMEO (1 * NFS_HZ) /* Default timeout = 1 second */
^
nfs/nfs_vfsops.c:1857:23: note: in expansion of macro 'NFS_TIMEO'
nprmt.timeo = NFS_TIMEO;
^
^~~~~~~~~
Change-Id: Id59274dc29db6dd7791c00bff9d304da0fd2ee3a
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
and simplify the attrbitue conversion between NFSv3 and NuttX Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com> Change-Id: I7cdbb7fdcb19a8b1be0835ba050f0fd1a2de5ffe
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com> Change-Id: If21f46b02d16609398ca0de57235c7f846b3d662
since we should update the buffer size before transfer happen, and handle the attribute existence variance correctly. Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com> Change-Id: Ie66c7155d52a7392270e1f9133a6f94152b50656
and fix other typo issue Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com> Change-Id: Icf7e5f7f32867277e5c4abaf18cbe5a4eefdedec
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com> Change-Id: Id9851220ca045f133b58b3e49802452964007f77
and the duplicated root handle storage Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com> Change-Id: I2e66ff602fcf2b2645b6d9cccaf3e845b611827c
patacongo
pushed a commit
that referenced
this pull request
Mar 1, 2020
* fs/nfs: Remove all nfs_checkmount call. The check just waste cpu cycle since nobody will set nm_mounted to false, and remove the unused fields(nm_mounted and n_flags) and related flags too
* fs/nfs: Fix the definition not confirm to RFC 1813 and other minor issue(unused, typo, duplication, alignment...)
* fs/nfs: Always represent error with negative number and remove the unused arguments from function
* fs/nfs: Set socket receive timeout with nfs_args->timeo and fix warning:
nfs/nfs.h:59:28: warning: large integer implicitly truncated to unsigned type [-Woverflow]
#define NFS_TIMEO (1 * NFS_HZ) /* Default timeout = 1 second */
^
nfs/nfs_vfsops.c:1857:23: note: in expansion of macro 'NFS_TIMEO'
nprmt.timeo = NFS_TIMEO;
^
^~~~~~~~~
* fs/nfs: Update the file attribute correctly in nfs_filetruncate and simplify the attrbitue conversion between NFSv3 and NuttX
* fs/nfs: Remove the unfinished and buggy EXCLUSIVE creation mode
* fs/nfs: Call nfs_fsinfo in nfs_bind instead of nfs_statfs since we should update the buffer size before transfer happen, and handle the attribute existence variance correctly.
* fs/nfs: Shouldn't insert node into list again in nfs_dup and fix other typo issue
* fs/nfs: Should skip . and .. in nfs_readdir
* fs/nfs: Remove the unnecessary dynamic allocation and the duplicated root handle storage
aenrbes
pushed a commit
to aenrbes/nuttx-on-litex-vexriscv
that referenced
this pull request
Mar 20, 2020
* fs/nfs: Remove all nfs_checkmount call. The check just waste cpu cycle since nobody will set nm_mounted to false, and remove the unused fields(nm_mounted and n_flags) and related flags too
* fs/nfs: Fix the definition not confirm to RFC 1813 and other minor issue(unused, typo, duplication, alignment...)
* fs/nfs: Always represent error with negative number and remove the unused arguments from function
* fs/nfs: Set socket receive timeout with nfs_args->timeo and fix warning:
nfs/nfs.h:59:28: warning: large integer implicitly truncated to unsigned type [-Woverflow]
#define NFS_TIMEO (1 * NFS_HZ) /* Default timeout = 1 second */
^
nfs/nfs_vfsops.c:1857:23: note: in expansion of macro 'NFS_TIMEO'
nprmt.timeo = NFS_TIMEO;
^
^~~~~~~~~
* fs/nfs: Update the file attribute correctly in nfs_filetruncate and simplify the attrbitue conversion between NFSv3 and NuttX
* fs/nfs: Remove the unfinished and buggy EXCLUSIVE creation mode
* fs/nfs: Call nfs_fsinfo in nfs_bind instead of nfs_statfs since we should update the buffer size before transfer happen, and handle the attribute existence variance correctly.
* fs/nfs: Shouldn't insert node into list again in nfs_dup and fix other typo issue
* fs/nfs: Should skip . and .. in nfs_readdir
* fs/nfs: Remove the unnecessary dynamic allocation and the duplicated root handle storage
cwespressif
pushed a commit
to cwespressif/incubator-nuttx
that referenced
this pull request
Apr 3, 2024
…om_psram_and_iram xtensa/esp32s3: Support malloc from external RAM and internal RAM
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 6, 2024
…zl error [elxr] (error apache#412) unresolved symbols: 1 __builtin_clzl from libc.a(lib_flsl.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 6, 2024
[elxr] (error apache#412) unresolved symbols: __builtin_signbit from libc.a(lib_dtoa_engine.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 6, 2024
[elxr] (error apache#412) unresolved symbols: __gh_long_long_printf from libc.a(lib_libbsprintf.o) __gh_float_printf from libc.a(lib_libbsprintf.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 6, 2024
[elxr] (error apache#412) unresolved symbols: __builtin_frame_address from libarch.a(arm_checkstack.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 6, 2024
…zl error [elxr] (error apache#412) unresolved symbols: 1 __builtin_clzl from libc.a(lib_flsl.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 6, 2024
[elxr] (error apache#412) unresolved symbols: __builtin_signbit from libc.a(lib_dtoa_engine.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 6, 2024
[elxr] (error apache#412) unresolved symbols: __gh_long_long_printf from libc.a(lib_libbsprintf.o) __gh_float_printf from libc.a(lib_libbsprintf.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 6, 2024
[elxr] (error apache#412) unresolved symbols: __builtin_frame_address from libarch.a(arm_checkstack.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 6, 2024
[elxr] (error apache#412) unresolved symbols: __builtin_frame_address from libarch.a(arm_checkstack.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 10, 2024
…zl error [elxr] (error apache#412) unresolved symbols: 1 __builtin_clzl from libc.a(lib_flsl.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 10, 2024
[elxr] (error apache#412) unresolved symbols: __builtin_signbit from libc.a(lib_dtoa_engine.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 10, 2024
[elxr] (error apache#412) unresolved symbols: __gh_long_long_printf from libc.a(lib_libbsprintf.o) __gh_float_printf from libc.a(lib_libbsprintf.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 10, 2024
[elxr] (error apache#412) unresolved symbols: __builtin_frame_address from libarch.a(arm_checkstack.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
added a commit
to extinguish/nuttx
that referenced
this pull request
Aug 10, 2024
[elxr] (error apache#412) unresolved symbols: 1 __gh_fputs_stdout from libapps.a(ostest_main.c.home.guoshichao.work_profile.vela_os.vela_car_4.apps.testing.ostest_1.o) Signed-off-by: guoshichao <guoshichao@xiaomi.com>
extinguish
added a commit
to extinguish/nuttx
that referenced
this pull request
Aug 10, 2024
the "__gh_set_errno" function are required by ghs "exp2", and "exp2" is not used in our project, so we can use "weak exp2" to avoid this error [elxr] (error apache#412) unresolved symbols: 1 __gh_set_errno from libmath_sd.a(indexp2.o) Signed-off-by: guoshichao <guoshichao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 11, 2024
[elxr] (error apache#412) unresolved symbols: __builtin_frame_address from libarch.a(arm_checkstack.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 11, 2024
…zl error [elxr] (error apache#412) unresolved symbols: 1 __builtin_clzl from libc.a(lib_flsl.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 11, 2024
[elxr] (error apache#412) unresolved symbols: __builtin_signbit from libc.a(lib_dtoa_engine.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 11, 2024
[elxr] (error apache#412) unresolved symbols: __gh_long_long_printf from libc.a(lib_libbsprintf.o) __gh_float_printf from libc.a(lib_libbsprintf.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
added a commit
to extinguish/nuttx
that referenced
this pull request
Aug 11, 2024
[elxr] (error apache#412) unresolved symbols: 1 __gh_fputs_stdout from libapps.a(ostest_main.c.home.guoshichao.work_profile.vela_os.vela_car_4.apps.testing.ostest_1.o) Signed-off-by: guoshichao <guoshichao@xiaomi.com>
extinguish
added a commit
to extinguish/nuttx
that referenced
this pull request
Aug 11, 2024
the "__gh_set_errno" function are required by ghs "exp2", and "exp2" is not used in our project, so we can use "weak exp2" to avoid this error [elxr] (error apache#412) unresolved symbols: 1 __gh_set_errno from libmath_sd.a(indexp2.o) Signed-off-by: guoshichao <guoshichao@xiaomi.com>
acassis
pushed a commit
that referenced
this pull request
Aug 11, 2024
[elxr] (error #412) unresolved symbols: __builtin_frame_address from libarch.a(arm_checkstack.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 12, 2024
[elxr] (error apache#412) unresolved symbols: __builtin_signbit from libc.a(lib_dtoa_engine.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
anchao
pushed a commit
that referenced
this pull request
Aug 19, 2024
[elxr] (error #412) unresolved symbols: __builtin_signbit from libc.a(lib_dtoa_engine.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
added a commit
to extinguish/nuttx
that referenced
this pull request
Aug 24, 2024
we add ghs header file support using to fix the following link error: [elxr] (error apache#412) unresolved symbols: 1 __sync_synchronize from libopenamp.a(io.o) Signed-off-by: guoshichao <guoshichao@xiaomi.com>
xiaoxiang781216
pushed a commit
that referenced
this pull request
Aug 24, 2024
we add ghs header file support using to fix the following link error: [elxr] (error #412) unresolved symbols: 1 __sync_synchronize from libopenamp.a(io.o) Signed-off-by: guoshichao <guoshichao@xiaomi.com>
13627105546
pushed a commit
to 13627105546/nuttx
that referenced
this pull request
Aug 26, 2024
we add ghs header file support using to fix the following link error: [elxr] (error apache#412) unresolved symbols: 1 __sync_synchronize from libopenamp.a(io.o) Signed-off-by: guoshichao <guoshichao@xiaomi.com>
shizhenghui
pushed a commit
to shizhenghui/nuttx
that referenced
this pull request
Sep 10, 2024
we add ghs header file support using to fix the following link error: [elxr] (error apache#412) unresolved symbols: 1 __sync_synchronize from libopenamp.a(io.o) Signed-off-by: guoshichao <guoshichao@xiaomi.com>
medexs
pushed a commit
to medexs/nuttx
that referenced
this pull request
Sep 19, 2024
[elxr] (error apache#412) unresolved symbols: __builtin_signbit from libc.a(lib_dtoa_engine.o) Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
medexs
pushed a commit
to medexs/nuttx
that referenced
this pull request
Sep 19, 2024
we add ghs header file support using to fix the following link error: [elxr] (error apache#412) unresolved symbols: 1 __sync_synchronize from libopenamp.a(io.o) Signed-off-by: guoshichao <guoshichao@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.