CXD56: move isx012 driver to board specific drivers #456
Conversation
| # ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
| # POSSIBILITY OF SUCH DAMAGE. | ||
| # | ||
| ############################################################################ |
There was a problem hiding this comment.
I know that you are really only moving a file, but the requirement is that all new files must have Apache 2.0 headers or they cannot come into the repostiory. Please replace this header with one like that in boards/z80/ez80/z20x/src/Makefile -- Note that there is no copyright or author information in the header.
There was a problem hiding this comment.
The same applies to ixx012.c which Github in all of its wisdom will not let me see. Good example for C at sched/sched/sched_getcpu.c
There was a problem hiding this comment.
I am seeing this error in the automated build runs:
====================================================================================
Configuration/Tool: spresense/audio,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Copy files
Select CONFIG_HOST_LINUX=y
Refreshing...
Disabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
Refreshing...
Building NuttX...
------------------------------------------------------------------------------------
platform/camera/Make.defs:1: *** missing separator. Stop.
platform/camera/Make.defs:1: *** missing separator. Stop.
make: *** [drivers/libdrivers.a] Error 2
make: *** Waiting for unfinished jobs....
make: *** wait: No child processes. Stop.
##[error]Process completed with exit code 2.
Reference: https://github.com/apache/incubator-nuttx/runs/491609128
patacongo
left a comment
patacongo
left a comment
There was a problem hiding this comment.
Apache 2.0 license and header (with no copyright or authors) required for all new files (and moved?) files.
This sensor driver needs rework to match the needed layout for standar NuttX driver. In the meantime it is moved to board specific sensors to fix the violation. Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
The SPECIFIC_DRIVERS configuration was removed from the drivers Kconfig and the build will ignore the specific drivers. This patch enables the config locally for the CXD56 board Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
…rebase-2402 [T3PW] [mainline rebase] rebase Nuttx mainline code w2402
2 participants
workaround for issue 438
#438