Skip to content

Conversation

@GUIDINGLI
Copy link
Contributor

@GUIDINGLI GUIDINGLI commented Jan 28, 2022

Summary

idle: remove heap & stack check in idle thread. See the discussion here: #5266

Impact

idle
heap & stack check

Testing

VELA

Copy link
Contributor

@davids5 davids5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jerpelea jerpelea self-requested a review January 28, 2022 13:46
Copy link
Contributor

@jerpelea jerpelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoxiang781216
Copy link
Contributor

@a-lunev please try this patch.

Signed-off-by: ligd <liguiding1@xiaomi.com>
Copy link
Contributor

@pkarashchenko pkarashchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@a-lunev
Copy link
Contributor

a-lunev commented Jan 28, 2022

@a-lunev please try this patch.

@xiaoxiang781216 Do you mean on some particular config?

@a-lunev
Copy link
Contributor

a-lunev commented Jan 28, 2022

@a-lunev please try this patch.

@xiaoxiang781216 I have tested it now using default sim:tcpblaster config (tested both CONFIG_DEBUG_MM=n and =y). The TCP throughput of RX and TX is not reduced (if you were concerned about the performance).
And it does not crash.

@xiaoxiang781216 xiaoxiang781216 merged commit d8c2610 into apache:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants