os init_state: add new state OSINIT_OSIDLELOOP #5577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ligd <liguiding1@xiaomi.com>
|
|
||
| /* Add the new entry to the end of the list of registered callbacks */ | ||
|
|
||
| if (OSINIT_OS_READY()) |
Contributor
There was a problem hiding this comment.
Why this condition is removed? I mean why not keeping it and changing to if (!OSINIT_OS_INITIALIZING())?
Contributor
Author
There was a problem hiding this comment.
Don't need.
Because when in system init state, we allow user to get lock.
xiaoxiang781216
approved these changes
Feb 21, 2022
xiaoxiang781216
approved these changes
Feb 21, 2022
Contributor
|
This is for distinguish we are in init idle or idle loop. Use for assertion for sem_trywait & sem_wait Signed-off-by: ligd <liguiding1@xiaomi.com>
xiaoxiang781216
approved these changes
Feb 22, 2022
pkarashchenko
approved these changes
Feb 22, 2022
Contributor
|
Hmm, spresense:elf now failed with this PR. |
Contributor
|
@masayuki2009 do you think we should revert the change until we clarify your case? |
Contributor
@pkarashchenko @GUIDINGLI |
Contributor
Author
|
Can you share the run & test cmd ? |
Contributor
Author
|
@masayuki2009 |
Contributor
|
Please see nuttx/boards/risc-v/k210/maix-bit/README-qemu.txt to run maix-bit:kostest. |
Contributor
Author
|
@masayuki2009 ligd@Opt:~/platform/mainline/nuttx$ qemu-system-riscv64 -nographic -machine sifive_u -bios ./nuttx But, with maix-bit:kostest, I meet this error: |
Contributor
As I wrote in README-qemu.txt |
Contributor
Author
|
@masayuki2009 Here is the new PR: |
Contributor
Author
|
@masayuki2009 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
os init_state: add new state OSINIT_OSIDLELOOP
This is for distinguish we are in init idle or idle loop.
Use for assertion for sem_trywait & sem_wait
Impact
wait/try wait in IDLE thread
Testing
VELA