Skip to content

Fix imx6 #5633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaoxiang781216 merged 2 commits into from
Feb 28, 2022
Merged

Fix imx6 #5633

xiaoxiang781216 merged 2 commits into from
Feb 28, 2022

Conversation

@masayuki2009
Copy link
Contributor

@masayuki2009 masayuki2009 commented Feb 28, 2022

Summary

  • This PR contains the following 2 commits
  • commit1: arch: imx6: Refactor imx_lowputc()
    • Remove '\n' -> '\r\n' conversion
    • Remove waiting for FIFO empty after sending a character
    • Remove CONFIG_DEBUG_FEATURES
  • commit2: Remove sem_t from imx_serial.c
    • I noticed that when exiting getprime, DEBUGASSERT happens in
      nxsem_wait()
    • Finally, I found that up_putc() uses nxsem_wait()
    • This commit fixes this issue by removing the semaphore.
    • Also, up_putc() now calls imx_lowputc()

Impact

  • None

Testing

  • Tested with sabre-6quad:netknsh (not merged yet)

@masayuki2009
arch: imx6: Refactor imx_lowputc()
b29d07f 
Summary:
- Remove '\n' -> '\r\n' conversion
- Remove waiting for FIFO empty after sending a character
- Remove CONFIG_DEBUG_FEATURES

Impact:
- None

Testing:
- Tested with sabre-6quad:netknsh (not merged yet)

Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
@masayuki2009
arch: imx6: Remove sem_t from imx_serial.c
a906d85 
Summary:
- I noticed that when exiting getprime, DEBUGASSERT happens in
  nxsem_wait()
- Finally, I found that up_putc() uses nxsem_wait()
- This commit fixes this issue by removing the semaphore.
- Also, up_putc() now calls imx_lowputc()

Impact:
- None

Testing:
- Tested with sabre-6quad:netknsh (not merged yet)

Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
@masayuki2009 masayuki2009 mentioned this pull request Feb 28, 2022
Merged
@xiaoxiang781216 xiaoxiang781216 merged commit 56e0e6a into apache:master Feb 28, 2022
@masayuki2009 masayuki2009 deleted the fix_imx6 branch March 17, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@masayuki2009 @xiaoxiang781216