Skip to content

fs/mmap/msync: support msync and fix minor issue #5997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Donny9 wants to merge 3 commits into from
Closed

fs/mmap/msync: support msync and fix minor issue #5997

Donny9 wants to merge 3 commits into from

Conversation

@Donny9
Copy link
Contributor

@Donny9 Donny9 commented Apr 7, 2022

Summary

fs/mmap/msync: support msync and fix some minor issue

Follow: https://man7.org/linux/man-pages/man2/msync.2.html

Impact

Support msync

Testing

Ci

Donny9 added 3 commits April 7, 2022 12:05
@Donny9
syscall/ummap: remove CONFIG_FS_RAMMAP because ummap always exist
1d2e390 
Signed-off-by: Jiuzhu Dong <dongjiuzhu1@xiaomi.com>
@Donny9
fs/mmap/rammap: fix minor issue
82e0972 
Signed-off-by: Jiuzhu Dong <dongjiuzhu1@xiaomi.com>
@Donny9
fs/msync: support msync
4f73a61 
follow:https://man7.org/linux/man-pages/man2/msync.2.html

Signed-off-by: Jiuzhu Dong <dongjiuzhu1@xiaomi.com>
@yamt
Copy link
Contributor

yamt commented Apr 7, 2022 •
edited
Loading

  • don't you need to distinguish MAP_SHARED/MAP_PRIVATE? copy-on-write mapping should not be written back to the file.
  • don't you need some reference counting on the file? i guess the file can be closed immediately after mmap.
  • i guess mmap should not modify file offset. (not specific to this PR)

yamt
yamt requested changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@yamt yamt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i commented a few questions

@xiaoxiang781216
Copy link
Contributor

xiaoxiang781216 commented Jan 10, 2023

@Donny9 we can implement with the new mmap infrastructure which is simpler now: #8000 and #8026.

@Donny9 Donny9 closed this Jul 31, 2023
@crafcat7 crafcat7 mentioned this pull request Aug 20, 2024
Closed
@crafcat7 crafcat7 mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yamt yamt yamt requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Donny9 @yamt @xiaoxiang781216