Skip to content

RISC-V: add C++ support to crt0 #6235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaoxiang781216 merged 1 commit into from
May 18, 2022
Merged

RISC-V: add C++ support to crt0 #6235

xiaoxiang781216 merged 1 commit into from
May 18, 2022

Conversation

@pussuw
Copy link
Contributor

@pussuw pussuw commented May 11, 2022

Summary

Adds C++ support to CRT

Impact

Testing

icicle:knsh

pussuw
pussuw commented May 11, 2022
View reviewed changes
xiaoxiang781216
xiaoxiang781216 reviewed May 11, 2022
View reviewed changes
pkarashchenko
pkarashchenko reviewed May 12, 2022
View reviewed changes
pkarashchenko
pkarashchenko reviewed May 12, 2022
View reviewed changes
@pussuw pussuw force-pushed the riscv_cxx_support branch from 77a2737 to a082fb1 Compare May 17, 2022 06:38
@pussuw
Copy link
Contributor Author

pussuw commented May 17, 2022

I think this file is not even compiled by CI so the build error is not my doing.

(Reason I think this file is not compiled: it is compiled by make import which I don't think is part of CI?)

@Ouss4
Copy link
Member

Ouss4 commented May 17, 2022

I think this file is not even compiled by CI so the build error is not my doing.

(Reason I think this file is not compiled: it is compiled by make import which I don't think is part of CI?)

It's related to the latest version of esptool (#6281). Let's ignore it for this PR.

pkarashchenko
pkarashchenko reviewed May 17, 2022
View reviewed changes
pkarashchenko
pkarashchenko approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@pkarashchenko pkarashchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkarashchenko
Copy link
Contributor

pkarashchenko commented May 17, 2022

Please rebase on top of the latest mainline to fix the CI issues

@pussuw pussuw force-pushed the riscv_cxx_support branch from a082fb1 to 90332ca Compare May 18, 2022 06:26
@pkarashchenko
Copy link
Contributor

pkarashchenko commented May 18, 2022

@xiaoxiang781216 I do not have any comments. Pleas merge if your questions are addressed

@xiaoxiang781216
Copy link
Contributor

xiaoxiang781216 commented May 18, 2022

@xiaoxiang781216 I do not have any comments. Pleas merge if your questions are addressed

No, let's merge this patch first. I am preparing patch to unify c++ constructor/destructor, will submit when it's ready.

@xiaoxiang781216 xiaoxiang781216 merged commit 12476e1 into apache:master May 18, 2022
@pussuw pussuw deleted the riscv_cxx_support branch May 18, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 left review comments

@pkarashchenko pkarashchenko pkarashchenko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pussuw @Ouss4 @pkarashchenko @xiaoxiang781216