Skip to content

include:add recursive lock #6279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaoxiang781216 merged 1 commit into from
May 24, 2022
Merged

include:add recursive lock #6279

xiaoxiang781216 merged 1 commit into from
May 24, 2022

Conversation

@anjiahao1
Copy link
Contributor

@anjiahao1 anjiahao1 commented May 16, 2022 •
edited
Loading

Signed-off-by: anjiahao anjiahao@xiaomi.com

Summary

add recurive lock

plan

  1. Replace all duplicate recursive locks with the current recursive lock implementation,eg(net_lock or inode_lock .. maybe more then)
  2. Use mutex to replace all places in nuttx that use sem as a lock
    3.Then change the default behavior of sem，it associated with
    RP5070

@anjiahao1 anjiahao1 force-pushed the rmutex branch 2 times, most recently from 0c0c3ad to 282d9b7 Compare May 16, 2022 11:05
@xiaoxiang781216
Copy link
Contributor

xiaoxiang781216 commented May 17, 2022

@anjiahao1 please rebase to the last mainline. CI error is fixed here: #6281

pkarashchenko
pkarashchenko reviewed May 17, 2022
View reviewed changes
@anjiahao1 anjiahao1 force-pushed the rmutex branch 2 times, most recently from de0d19f to 2f68075 Compare May 18, 2022 12:52
gustavonihei
gustavonihei reviewed May 18, 2022
View reviewed changes
davids5
davids5 reviewed May 19, 2022
View reviewed changes
davids5
davids5 requested changes May 19, 2022
View reviewed changes
Copy link
Contributor

@davids5 davids5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are operation in DEBUGASSERTS!

davids5
davids5 requested changes May 20, 2022
View reviewed changes
Copy link
Contributor

@davids5 davids5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline

@davids5 davids5 self-requested a review May 20, 2022 10:51
xiaoxiang781216
xiaoxiang781216 reviewed May 20, 2022
View reviewed changes
@xiaoxiang781216
Copy link
Contributor

xiaoxiang781216 commented May 23, 2022

@davids5 and @pkarashchenko could you take a look again?

pkarashchenko
pkarashchenko reviewed May 24, 2022
View reviewed changes
@anjiahao1
include:add recursive lock
46bc8e6 
Signed-off-by: anjiahao <anjiahao@xiaomi.com>
pkarashchenko
pkarashchenko approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@pkarashchenko pkarashchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xiaoxiang781216 xiaoxiang781216 merged commit 247a13c into apache:master May 24, 2022
@xiaoxiang781216 xiaoxiang781216 linked an issue May 27, 2022 that may be closed by this pull request
Replace all place which use semaphore as lock with mutex wrapper #5184
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anchao anchao anchao left review comments

@gustavonihei gustavonihei gustavonihei left review comments

@pkarashchenko pkarashchenko pkarashchenko approved these changes

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

@davids5 davids5 Awaiting requested review from davids5

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace all place which use semaphore as lock with mutex wrapper

6 participants

@anjiahao1 @xiaoxiang781216 @anchao @davids5 @pkarashchenko @gustavonihei