sched/pthread: Should call up_exit in pthread_exit #6329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since _exit may kill all sibling thread when HAVE_GROUP_MEMBERS equal true. Regressed by: commit 622677d Author: Ville Juven <ville.juven@unikie.com> Date: Mon May 2 15:15:06 2022 +0300 libc: Implement exit, atexit, on_exit and cxa_exit on the user side For CONFIG_BUILD_KERNEL using the sched/task/task_exithook implementation will just not work. It calls user code with kernel privileges which is a bit of a security issue. Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
pkarashchenko
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
since _exit may kill all sibling thread when
HAVE_GROUP_MEMBERS equal true. Regressed by(#6197):
Impact
Avoid pthread_exit terminate all thread in the same process
Testing
ostest