Revert "Optimize syslog_write performance"

arch/arm/src/common/Make.defs

@@ -24,7 +24,7 @@ CMN_CSRCS += arm_allocateheap.c arm_assert.c arm_blocktask.c
 CMN_CSRCS += arm_createstack.c arm_exit.c arm_fullcontextrestore.c
 CMN_CSRCS += arm_initialize.c arm_lowputs.c
 CMN_CSRCS += arm_modifyreg16.c arm_modifyreg32.c
-CMN_CSRCS += arm_modifyreg8.c arm_nputs.c arm_releasepending.c
+CMN_CSRCS += arm_modifyreg8.c arm_puts.c arm_releasepending.c
 CMN_CSRCS += arm_releasestack.c arm_reprioritizertr.c arm_saveusercontext.c
 CMN_CSRCS += arm_stackframe.c arm_switchcontext.c
 CMN_CSRCS += arm_vfork.c arm_unblocktask.c arm_usestack.c

arch/arm/src/common/arm_nputs.c → arch/arm/src/common/arm_puts.c

@@ -1,5 +1,5 @@
 /****************************************************************************
- * arch/arm/src/common/arm_nputs.c
+ * arch/arm/src/common/arm_puts.c
  *
  * Licensed to the Apache Software Foundation (ASF) under one or more
  * contributor license agreements.  See the NOTICE file distributed with
@@ -25,21 +25,23 @@
 #include <nuttx/config.h>
 #include <nuttx/arch.h>
 
+#include "arm_internal.h"
+
 /****************************************************************************
  * Public Functions
  ****************************************************************************/
 
 /****************************************************************************
- * Name: up_nputs
+ * Name: up_puts
  *
  * Description:
  *   This is a low-level helper function used to support debug.
  *
  ****************************************************************************/
 
-void up_nputs(const char *str, size_t len)
+void up_puts(const char *str)
 {
-  while (*str && len-- > 0)
+  while (*str)
     {
       up_putc(*str++);
     }

arch/arm/src/common/arm_semi_syslog.c

@@ -27,6 +27,8 @@
 
 #include <syscall.h>
 
+#include "arm_internal.h"
+
 #ifdef CONFIG_ARM_SEMIHOSTING_SYSLOG
 
 /****************************************************************************
@@ -52,25 +54,15 @@ int up_putc(int ch)
 }
 
 /****************************************************************************
- * Name: up_nputs
+ * Name: up_puts
  *
  * Description:
  *   Output a string on the console
  *
  ****************************************************************************/
 
-void up_nputs(const char *str, size_t len)
+void up_puts(const char *str)
 {
-  if (len == ~((size_t)0))
-    {
-      smh_call(SEMI_SYSLOG_WRITE0, (char *)str);
-    }
-  else
-    {
-      while (len-- > 0)
-        {
-          up_putc(*str++);
-        }
-    }
+  smh_call(SEMI_SYSLOG_WRITE0, (char *)str);
 }
 #endif

arch/arm64/src/common/Make.defs

@@ -43,7 +43,7 @@ endif
 
 # Common C source files ( OS call up_xxx)
 CMN_CSRCS =  arm64_initialize.c arm64_initialstate.c arm64_boot.c
-CMN_CSRCS += arm64_nputs.c arm64_idle.c arm64_copystate.c
+CMN_CSRCS += arm64_idle.c arm64_copystate.c
 CMN_CSRCS += arm64_createstack.c arm64_releasestack.c arm64_stackframe.c arm64_usestack.c
 CMN_CSRCS += arm64_task_sched.c arm64_exit.c arm64_vfork.c arm64_reprioritizertr.c
 CMN_CSRCS += arm64_releasepending.c arm64_unblocktask.c arm64_blocktask.c

arch/avr/src/at32uc3/Make.defs

@@ -31,7 +31,7 @@ CMN_CSRCS += up_initialize.c up_initialstate.c
 CMN_CSRCS += up_modifyreg8.c up_modifyreg16.c up_modifyreg32.c
 CMN_CSRCS += up_releasepending.c up_releasestack.c up_reprioritizertr.c
 CMN_CSRCS += up_schedulesigaction.c up_sigdeliver.c up_stackframe.c
-CMN_CSRCS += up_unblocktask.c up_usestack.c up_doirq.c up_nputs.c
+CMN_CSRCS += up_unblocktask.c up_usestack.c up_doirq.c up_puts.c
 
 # Configuration-dependent common files
 

arch/avr/src/at90usb/Make.defs

@@ -29,7 +29,7 @@ CMN_CSRCS  = up_allocateheap.c up_assert.c up_blocktask.c up_copystate.c
 CMN_CSRCS += up_createstack.c up_doirq.c up_exit.c  up_idle.c up_initialize.c
 CMN_CSRCS += up_initialstate.c up_irq.c up_lowputs.c
 CMN_CSRCS += up_mdelay.c up_modifyreg8.c up_modifyreg16.c up_modifyreg32.c
-CMN_CSRCS += up_nputs.c up_releasepending.c up_releasestack.c
+CMN_CSRCS += up_puts.c up_releasepending.c up_releasestack.c
 CMN_CSRCS += up_reprioritizertr.c up_schedulesigaction.c up_sigdeliver.c
 CMN_CSRCS += up_stackframe.c up_udelay.c up_unblocktask.c up_usestack.c
 

arch/avr/src/atmega/Make.defs

@@ -29,7 +29,7 @@ CMN_CSRCS  = up_allocateheap.c up_assert.c up_blocktask.c up_copystate.c
 CMN_CSRCS += up_createstack.c up_doirq.c up_exit.c  up_idle.c up_initialize.c
 CMN_CSRCS += up_initialstate.c up_irq.c up_lowputs.c
 CMN_CSRCS += up_mdelay.c up_modifyreg8.c up_modifyreg16.c up_modifyreg32.c
-CMN_CSRCS += up_nputs.c up_releasepending.c up_releasestack.c
+CMN_CSRCS += up_puts.c up_releasepending.c up_releasestack.c
 CMN_CSRCS += up_reprioritizertr.c up_schedulesigaction.c up_sigdeliver.c
 CMN_CSRCS += up_stackframe.c up_udelay.c up_unblocktask.c up_usestack.c
 

arch/hc/src/common/up_nputs.c → arch/avr/src/common/up_puts.c

@@ -1,5 +1,5 @@
 /****************************************************************************
- * arch/hc/src/common/up_nputs.c
+ * arch/avr/src/common/up_puts.c
  *
  * Licensed to the Apache Software Foundation (ASF) under one or more
  * contributor license agreements.  See the NOTICE file distributed with
@@ -25,6 +25,8 @@
 #include <nuttx/config.h>
 #include <nuttx/arch.h>
 
+#include "up_internal.h"
+
 /****************************************************************************
  * Pre-processor Definitions
  ****************************************************************************/
@@ -42,16 +44,16 @@
  ****************************************************************************/
 
 /****************************************************************************
- * Name: up_nputs
+ * Name: up_puts
  *
  * Description:
  *   This is a low-level helper function used to support debug.
  *
  ****************************************************************************/
 
-void up_nputs(const char *str, size_t len)
+void up_puts(const char *str)
 {
-  while (*str && len-- > 0)
+  while (*str)
     {
       up_putc(*str++);
     }

arch/z16/src/common/z16_nputs.c → arch/ceva/src/common/up_puts.c

@@ -1,5 +1,5 @@
 /****************************************************************************
- * arch/z16/src/common/z16_nputs.c
+ * arch/ceva/src/common/up_puts.c
  *
  * Licensed to the Apache Software Foundation (ASF) under one or more
  * contributor license agreements.  See the NOTICE file distributed with
@@ -30,16 +30,16 @@
  ****************************************************************************/
 
 /****************************************************************************
- * Name: up_nputs
+ * Name: up_puts
  *
  * Description:
  *   This is a low-level helper function used to support debug.
  *
  ****************************************************************************/
 
-void up_nputs(const char *str, size_t len)
+void up_puts(const char *str)
 {
-  while (*str && len-- > 0)
+  while (*str)
     {
       up_putc(*str++);
     }

arch/x86/src/common/up_nputs.c → arch/hc/src/common/up_puts.c

@@ -1,5 +1,5 @@
 /****************************************************************************
- * arch/x86/src/common/up_nputs.c
+ * arch/hc/src/common/up_puts.c
  *
  * Licensed to the Apache Software Foundation (ASF) under one or more
  * contributor license agreements.  See the NOTICE file distributed with
@@ -23,8 +23,11 @@
  ****************************************************************************/
 
 #include <nuttx/config.h>
+
 #include <nuttx/arch.h>
 
+#include "up_internal.h"
+
 /****************************************************************************
  * Pre-processor Definitions
  ****************************************************************************/
@@ -42,16 +45,16 @@
  ****************************************************************************/
 
 /****************************************************************************
- * Name: up_nputs
+ * Name: up_puts
  *
  * Description:
  *   This is a low-level helper function used to support debug.
  *
  ****************************************************************************/
 
-void up_nputs(const char *str, size_t len)
+void up_puts(const char *str)
 {
-  while (*str && len-- > 0)
+  while (*str)
     {
       up_putc(*str++);
     }

arch/hc/src/m9s12/Make.defs

@@ -23,7 +23,7 @@ HEAD_ASRC = m9s12_vectors.S
 CMN_CSRCS  = up_allocateheap.c up_blocktask.c up_copystate.c up_createstack.c
 CMN_CSRCS += up_doirq.c up_exit.c up_idle.c up_initialize.c
 CMN_CSRCS += up_mdelay.c up_modifyreg16.c up_modifyreg32.c up_modifyreg8.c
-CMN_CSRCS += up_nputs.c up_releasepending.c up_releasestack.c up_reprioritizertr.c
+CMN_CSRCS += up_puts.c up_releasepending.c up_releasestack.c up_reprioritizertr.c
 CMN_CSRCS += up_stackframe.c up_udelay.c up_unblocktask.c up_usestack.c
 
 CHIP_ASRCS  = m9s12_start.S m9s12_lowputc.S m9s12_saveusercontext.S

arch/mips/src/common/mips_nputs.c → arch/mips/src/common/mips_puts.c

@@ -1,5 +1,5 @@
 /****************************************************************************
- * arch/mips/src/common/mips_nputs.c
+ * arch/mips/src/common/mips_puts.c
  *
  * Licensed to the Apache Software Foundation (ASF) under one or more
  * contributor license agreements.  See the NOTICE file distributed with
@@ -25,6 +25,8 @@
 #include <nuttx/config.h>
 #include <nuttx/arch.h>
 
+#include "mips_internal.h"
+
 /****************************************************************************
  * Pre-processor Definitions
  ****************************************************************************/
@@ -42,16 +44,16 @@
  ****************************************************************************/
 
 /****************************************************************************
- * Name: up_nputs
+ * Name: up_puts
  *
  * Description:
  *   This is a low-level helper function used to support debug.
  *
  ****************************************************************************/
 
-void up_nputs(const char *str, size_t len)
+void up_puts(const char *str)
 {
-  while (*str && len-- > 0)
+  while (*str)
     {
       up_putc(*str++);
     }

arch/mips/src/pic32mx/Make.defs

@@ -29,7 +29,7 @@ CMN_CSRCS  = mips_allocateheap.c mips_assert.c mips_blocktask.c mips_copystate.c
 CMN_CSRCS += mips_createstack.c mips_doirq.c mips_exit.c mips_initialize.c
 CMN_CSRCS += mips_initialstate.c mips_irq.c mips_lowputs.c
 CMN_CSRCS += mips_mdelay.c mips_modifyreg8.c mips_modifyreg16.c mips_modifyreg32.c
-CMN_CSRCS += mips_nputs.c mips_releasepending.c mips_releasestack.c
+CMN_CSRCS += mips_puts.c mips_releasepending.c mips_releasestack.c
 CMN_CSRCS += mips_reprioritizertr.c mips_schedulesigaction.c mips_sigdeliver.c
 CMN_CSRCS += mips_stackframe.c mips_swint0.c mips_udelay.c mips_unblocktask.c
 CMN_CSRCS += mips_usestack.c mips_vfork.c

arch/mips/src/pic32mz/Make.defs

@@ -29,7 +29,7 @@ CMN_CSRCS  = mips_allocateheap.c mips_assert.c mips_blocktask.c mips_copystate.c
 CMN_CSRCS += mips_createstack.c mips_doirq.c mips_exit.c mips_initialize.c
 CMN_CSRCS += mips_initialstate.c mips_irq.c mips_lowputs.c
 CMN_CSRCS += mips_mdelay.c mips_modifyreg8.c mips_modifyreg16.c mips_modifyreg32.c
-CMN_CSRCS += mips_nputs.c mips_releasepending.c mips_releasestack.c
+CMN_CSRCS += mips_puts.c mips_releasepending.c mips_releasestack.c
 CMN_CSRCS += mips_reprioritizertr.c mips_schedulesigaction.c mips_sigdeliver.c
 CMN_CSRCS += mips_stackframe.c mips_swint0.c mips_udelay.c mips_unblocktask.c
 CMN_CSRCS += mips_usestack.c mips_vfork.c

arch/or1k/src/common/up_nputs.c → arch/or1k/src/common/up_puts.c

@@ -1,5 +1,5 @@
 /****************************************************************************
- * arch/or1k/src/common/up_nputs.c
+ * arch/or1k/src/common/up_puts.c
  *
  * Licensed to the Apache Software Foundation (ASF) under one or more
  * contributor license agreements.  See the NOTICE file distributed with
@@ -25,21 +25,23 @@
 #include <nuttx/config.h>
 #include <nuttx/arch.h>
 
+#include "up_internal.h"
+
 /****************************************************************************
  * Public Functions
  ****************************************************************************/
 
 /****************************************************************************
- * Name: up_nputs
+ * Name: up_puts
  *
  * Description:
  *   This is a low-level helper function used to support debug.
  *
  ****************************************************************************/
 
-void up_nputs(const char *str, size_t len)
+void up_puts(const char *str)
 {
-  while (*str && len-- > 0)
+  while (*str)
     {
       up_putc(*str++);
     }

arch/or1k/src/mor1kx/Make.defs

@@ -41,7 +41,7 @@ CMN_CSRCS  = up_initialize.c \
              up_mdelay.c \
              up_idle.c \
              up_irq.c \
-             up_nputs.c \
+             up_puts.c \
              up_uart.c \
              up_timer.c \
              up_doirq.c \