-
Notifications
You must be signed in to change notification settings - Fork 1.5k
add heapcheck(memcheck) flag #6724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
davids5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pengxiang-hao -
The title and Summary, Impact, Testing do not document what this PR does. I makes is sound like you renamed and added a flag. Please document the changes herein and answer the questions Why it is needed and What does and How Please do this by editing the title and Summary, Impact, Testing above.
|
@xiaoxiang781216 - I think we cross posted. There have been no changes since I reviewed the PR and asked for changes. |
I think "The title and Summary, Impact, Testing" is updated, but the code isn't. @pengxiang-hao please update the code too. |
GH logs the edits. I do not see any since I posted. Do you? |
Signed-off-by: haopengxiang <haopengxiang@xiaomi.com>
1 for open heapcheck, 0 for close echo 1 > /proc/xxx/heapcheck echo 0 > /proc/xxx/heapcheck Signed-off-by: haopengxiang <haopengxiang@xiaomi.com>
|
@davids5 please review the update again, the change look good to me now. |
Summary
What
TCB_FLAG_MEM_CHECKbyTCB_FLAG_HEAPCHECKWhy
TCB_FLAG_MEM_CHECK,TCB_FLAG_HEAPCHECKshould be more suitable in such condition.kmm_checkcorruption().How
kmm_checkcorruption()with flexible flag control for developer to choose for each tcb.1 for open heapcheck, 0 for close
echo 1 > /proc/xxx/heapcheckecho 0 > /proc/xxx/heapcheckImpact
Using of
TCB_FLAG_MEM_CHECKmay need to be replaced withTCB_FLAG_HEAPCHECK.Testing
Vela CI