include:add sys/queue.h support form openbsd #6828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiang781216
approved these changes
Aug 10, 2022
Contributor
hartmannathan
left a comment
hartmannathan
left a comment
There was a problem hiding this comment.
Please add to LICENSE.
As @pkarashchenko points out, should also be wrapped by ALLOW_BSD_COMPONENTS.
anjiahao1
force-pushed
the
sys_queue
branch
3 times, most recently
from
b6f78a0 to
8bc5204
Compare
pkarashchenko
approved these changes
Aug 15, 2022
Contributor
pkarashchenko
left a comment
pkarashchenko
left a comment
There was a problem hiding this comment.
LGTM!
There are few places where redundant () can be removed.
Contributor
|
@pkarashchenko reviewing... |
Signed-off-by: anjiahao <anjiahao@xiaomi.com>
hartmannathan
approved these changes
Aug 16, 2022
Contributor
hartmannathan
left a comment
hartmannathan
left a comment
There was a problem hiding this comment.
Thanks for taking care of those issues. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: anjiahao anjiahao@xiaomi.com
Summary
some queue define
Impact
noting
Testing
ci