Fix timeout #76
Merged
Fix timeout #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is the email loop talk about why it is better to remove the option: https://groups.google.com/forum/#!topic/nuttx/AaNkS7oU6R0 Change-Id: Ib66c037752149ad4b2787ef447f966c77aa12aad Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
1.Consolidate absolute to relative timeout conversion into one place(_net_timedwait) 2.Drive the wait timeout logic by net_timedwait instead of devif_timer This patch help us remove devif_timer(period tick) to save the power in the future. Change-Id: I534748a5d767ca6da8a7843c3c2f993ed9ea77d4 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Change-Id: I657433806d5dc851ce9bd7722f191f467f9ad458 Signed-off-by: chao.an <anchao@xiaomi.com>
|
Minor issue: Enable CONFIG_NET_TCP_KEEPALIVE and then several references to struct timeval fail where sys/time.h is no longer included. |
Contributor
|
I have some concerns that this combines unrelated changes into the same PR. The result is that it is too large to review properly. It will take some time. |
Contributor
Author
Yes, the change is huge but related each other unfortunately. That is why is better to "Rebase and merge" instead of "Squash", so we can keep each change separate and revertable. |
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 10, 2024
"/mnt/yang/qixinwei_vela_warnings/nuttx/include/nuttx/spinlock.h", line 252: warning apache#76-D: argument to macro is empty SP_DSB(); ^ "/mnt/yang/qixinwei_vela_warnings/nuttx/include/nuttx/spinlock.h", line 261: warning apache#76-D: argument to macro is empty SP_DMB(); ^ "/mnt/yang/qixinwei_vela_warnings/nuttx/include/nuttx/spinlock.h", line 252: warning apache#76-D: argument to macro is empty SP_DSB(); ^ "/mnt/yang/qixinwei_vela_warnings/nuttx/include/nuttx/spinlock.h", line 261: warning apache#76-D: argument to macro is empty SP_DMB(); ^ "/mnt/yang/qixinwei_vela_warnings/nuttx/include/nuttx/spinlock.h", line 296: warning apache#76-D: argument to macro is empty SP_DSB(); ^ Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 11, 2024
"/mnt/yang/qixinwei_vela_warnings/nuttx/include/nuttx/spinlock.h", line 252: warning apache#76-D: argument to macro is empty SP_DSB(); ^ "/mnt/yang/qixinwei_vela_warnings/nuttx/include/nuttx/spinlock.h", line 261: warning apache#76-D: argument to macro is empty SP_DMB(); ^ "/mnt/yang/qixinwei_vela_warnings/nuttx/include/nuttx/spinlock.h", line 252: warning apache#76-D: argument to macro is empty SP_DSB(); ^ "/mnt/yang/qixinwei_vela_warnings/nuttx/include/nuttx/spinlock.h", line 261: warning apache#76-D: argument to macro is empty SP_DMB(); ^ "/mnt/yang/qixinwei_vela_warnings/nuttx/include/nuttx/spinlock.h", line 296: warning apache#76-D: argument to macro is empty SP_DSB(); ^ Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
acassis
pushed a commit
that referenced
this pull request
Aug 11, 2024
"/mnt/yang/qixinwei_vela_warnings/nuttx/include/nuttx/spinlock.h", line 252: warning #76-D: argument to macro is empty SP_DSB(); ^ "/mnt/yang/qixinwei_vela_warnings/nuttx/include/nuttx/spinlock.h", line 261: warning #76-D: argument to macro is empty SP_DMB(); ^ "/mnt/yang/qixinwei_vela_warnings/nuttx/include/nuttx/spinlock.h", line 252: warning #76-D: argument to macro is empty SP_DSB(); ^ "/mnt/yang/qixinwei_vela_warnings/nuttx/include/nuttx/spinlock.h", line 261: warning #76-D: argument to macro is empty SP_DMB(); ^ "/mnt/yang/qixinwei_vela_warnings/nuttx/include/nuttx/spinlock.h", line 296: warning #76-D: argument to macro is empty SP_DSB(); ^ Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue reported by:
https://groups.google.com/forum/#!topic/nuttx/AaNkS7oU6R0
https://groups.google.com/forum/#!topic/nuttx/nF0pfDkd3hA
https://lists.apache.org/thread.html/r9877de4a9c25890912d920cc15ca418368a9154212a5bf8e0c36a883%40<dev.nuttx.apache.org>